[Rust] Add WTX - WebSocket#809
Open
c410-f3r wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
/benchmark -f wtx-ws --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
Should be good now /benchmark -f wtx-ws --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
Erhh... Did a last minute modification. Let's see if this case will be resolved. /benchmark -f wtx-ws --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
👍 |
Owner
|
This should be marked as type: engine |
Contributor
Author
|
Oops... I should have used the higher level abstractions instead of manually accepting connections. Let me know if the code is now in good shape for the current label. |
Owner
|
Both production and tuned are framework territory/tier - requires a framework«s high level APIs (routing, middleware, handlers, etc) which is ofc always a gray territory as different technologies have their unique way of implementing web frameworks. WTX is as described as collection of low-level transport implementation tools. This entry reflects that - drives a bare frame echo with no router or middleware which leans to the engine definition, we are essentially measuring tokio performance here |
Contributor
Author
|
I see. The production tier requires a router/middleware. Next time such a feature will be implemented. Changing to |
Owner
It's not just that, production is reserved for frameworks with a strong ecossystem, currently we have some "production" entries that aren't really fit to be there and will be adjusted before the first official round, probably we will also change this classification system and the production equivalent will be only for frameworks with a community, ecossystem, full feature and an active team working on it, we will still be able to compare these with other frameworks on leaderboard but the distinction must exist because a production framework has a lot more constraints and implementation details than others |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new WebSocket implementation based on
WTX