Fix a crashing issue when toggling fullscreen mode #249
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change whenever I would toggle fullscreen mode in minecraft while in a world the game would crash with the error
java.lang.IllegalStateException: Framebuffer incomplete with error code: 36057. This was caused from the renderer trying to verify the depth textures and something else but the verify method was called prior to the resize changes being applied. From this I quite simply moved the method calls to a little later so that all the dimensions are the same and the game no longer crashes when I toggle fullscreen.Now I will confess since I know next to nothing about rendering or opengl I did use chatgpt to help but it appears to work and I didn't blindly copy and paste ¯_(ツ)_/¯