Repository navigation
Refactor: codex reviewer 수동 트리거 -> github action 으로 auto #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alphabeen
wants to merge
5
commits into
main
Choose a base branch
from
refactor/#40/review-codex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
75b6dbf
refactor: codex reviewer 수동 트리거 -> github action 으로 auto
alphabeen 3f112db
refactor: permissions 추가
alphabeen ca11760
pull_request -> pull_request_target
alphabeen edd3ea7
더미 AGENTS 추가, 추후 수정 요망
alphabeen 232b7dc
깃허브액션 down -> PR temp 수정
alphabeen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| # AGENTS.md | ||
|
|
||
| ## Review guidelines | ||
|
|
||
| - Always write review comments in Korean. | ||
| - Keep technical terms in English when they are standard in software engineering or machine learning. | ||
| - Be concise, but explain why the issue matters and how to fix it. | ||
| - Prioritize real bugs, regressions, security issues, deployment risks, and ML/data issues over style nitpicks. | ||
| - Avoid commenting on trivial formatting unless it can cause misunderstanding. | ||
|
|
||
| ## Project context | ||
|
|
||
| This repository is for an AI-Ops / MLOps style platform that includes: | ||
| - FastAPI backend | ||
| - OpenStack-related deployment/infrastructure integration | ||
| - ML-based prediction and anomaly detection pipelines | ||
| - Docker / GitHub Actions / self-hosted runner based deployment | ||
| - Database and metrics processing logic | ||
|
|
||
| When reviewing code, use this context and focus on operational safety and production reliability. | ||
|
|
||
| ## What to focus on | ||
|
|
||
| ### 1. Backend / API correctness | ||
| - Check for broken FastAPI route logic, invalid request/response handling, and exception paths. | ||
| - Flag missing validation, weak error handling, and inconsistent response formats. | ||
| - Check whether authentication or authorization-related logic is missing or bypassable. | ||
| - Watch for blocking I/O or heavy computation inside request handlers. | ||
|
|
||
| ### 2. ML / data pipeline risks | ||
| - Look for possible data leakage between train/validation/test. | ||
| - Check whether feature generation uses future information accidentally. | ||
| - Flag inconsistent preprocessing between training and inference. | ||
| - Check whether saved model artifacts, metadata, and scalers stay in sync. | ||
| - Watch for silent fallback behavior that could hide model failure. | ||
| - Flag suspicious metric calculations or evaluation logic. | ||
| - Check whether anomaly thresholds, smoothing, aggregation, or time-window logic can produce misleading alerts. | ||
|
|
||
| ### 3. Time-series / forecasting issues | ||
| - Be sensitive to ordering bugs, timestamp alignment problems, resampling errors, and off-by-one mistakes. | ||
| - Flag train/test splits that ignore temporal order. | ||
| - Check whether forward fill, interpolation, clipping, normalization, or lag feature generation can distort real behavior. | ||
| - Watch for target leakage through rolling statistics or future-dependent transformations. | ||
|
|
||
| ### 4. Infra / deployment safety | ||
| - Check whether Docker, GitHub Actions, and deployment logic can break production unexpectedly. | ||
| - Flag risky shell commands, destructive cleanup, and commands that may impact unrelated containers or files. | ||
| - Check for mistakes in image tags, registry login flow, compose commands, and self-hosted runner cleanup. | ||
| - Watch for secrets accidentally exposed in logs, code, workflow files, or exception messages. | ||
|
|
||
| ### 5. Database / persistence | ||
| - Flag schema mismatches, unsafe migrations, missing transactions, and inconsistent model persistence behavior. | ||
| - Check whether writes are idempotent where needed. | ||
| - Watch for race conditions or duplicate inserts in metric/history/alert flows. | ||
|
|
||
| ### 6. Security | ||
| - Flag hardcoded secrets, tokens, endpoints, or credentials. | ||
| - Flag missing permission checks. | ||
| - Flag dangerous deserialization, shell injection risks, path traversal risks, and unsafe subprocess usage. | ||
| - Be strict about logging sensitive operational data. | ||
|
|
||
| ## Review style | ||
|
|
||
| For each important issue: | ||
| - State the problem clearly in Korean. | ||
| - Explain why it is risky. | ||
| - Suggest a concrete fix. | ||
| - If severity is high, say so explicitly. | ||
|
|
||
| Preferred tone example: | ||
| - "이 부분은 `train/test leakage` 가능성이 있습니다." | ||
| - "현재 구현은 예측 시점 이후의 정보를 참조할 수 있어 시계열 평가가 왜곡될 수 있습니다." | ||
| - "이 workflow 단계는 self-hosted runner 환경에서 과도하게 파괴적일 수 있습니다." | ||
|
|
||
| ## What to ignore unless severe | ||
|
|
||
| - Minor naming preferences | ||
| - Personal style preferences | ||
| - Formatting differences already handled by formatter/linter | ||
| - Non-critical refactors that do not affect correctness, safety, or maintainability | ||
|
|
||
| ## Extra instructions | ||
|
|
||
| - When possible, prefer comments on correctness, reliability, and production impact. | ||
| - For ML-related pull requests, review like a careful ML engineer, not just a general code reviewer. | ||
| - For deployment-related pull requests, review like a cautious DevOps engineer. | ||
| - If a change looks intentional but risky, call out the risk without assuming the author is wrong. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 저장소 기준으로
.github/workflows아래에는deploy.yml만 있고, 이번 diff는 PR template에@codex review수동 댓글 안내만 추가합니다. 그래서 커밋 설명과 달리 Codex review가 자동으로 실행되지는 않으며, 실제 운영에서는 리뷰 누락이나 계속된 수동 호출을 유발합니다.pull_request등으로 트리거되는 workflow 파일을 실제로 추가하거나, 자동화가 준비되기 전까지는 이 안내 문구를 넣지 않는 쪽이 안전합니다.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이슈와 달리 task가 바뀜. 커밋 내역 참고해서 리뷰 넘길게요.