fix(pgvector): skip HNSW index creation when index already exists#83
Merged
Conversation
CREATE INDEX IF NOT EXISTS still requires table ownership and fails with 'must be owner of table' on managed Postgres (e.g. Cloud SQL) where the schema was bootstrapped by a different role. When the index exists from a prior run, we now skip the CREATE entirely by checking pg_class first. This prevents ANN search from being unnecessarily disabled, which was causing activation to fall back to Path B (fetch-all).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE INDEX IF NOT EXISTS still requires table ownership and fails with 'must be owner of table' on managed Postgres (e.g. Cloud SQL) where the schema was bootstrapped by a different role. When the index exists from a prior run, we now skip the CREATE entirely by checking pg_class first.
This prevents ANN search from being unnecessarily disabled, which was causing activation to fall back to Path B (fetch-all).