Repository navigation
The project is MThread Draw - #6
Merged
Merged
Conversation
Every name goes: import adbtouch becomes import mthread, autodraw becomes mthread_draw, the console script is mthread and the desktop entry point mthread-draw, the distribution is mthread-draw, the installer is MThreadDraw-x.y.z-x64.msi, the WinUI assembly and namespace are MThreadDraw, the Java package is com.mthread, AdbTouchError is MThreadError and ADBTOUCH_CACHE is MTHREAD_CACHE. The repository moves to MAXAWER/MThread-Draw. No compatibility shim, and none is owed: nothing has ever been released under the old names except a January pre-release of a different program, which is still there and now marked as such. The product's name has a space wherever a person reads it - the window title, the Start Menu entry, the installer's dialogs, the prose - and none wherever a machine does, which is why the mechanical pass could not be the whole job. Two things found along the way. The rename was first done by reading each file as text and writing it back, which is wrong on Windows: it flattened run.bat's CRLF endings. Doing it on bytes, sourced from the git index rather than the working tree, changes the names and nothing else. run.bat's stored line endings do change here, but only because .gitattributes has asked for eol=crlf all along and the blob was still CRLF; this normalises it. run.bat could never have fetched adb. Two backslashes had been lost from it long before today, so it looked for "platform-tools<BEL>db.exe" and tried to run "tools<FF>etch_platform_tools.py" - a formfeed and a bell where \a and \f used to be. Both restored. Tests pass, the injector jar is rebuilt against com.mthread, and the WinUI project builds clean under the new namespace. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project is renamed. Stacked on #5 — until that merges, this PR shows the
demo-assets commit too; after it, only the rename.
What changes
import adbtouchimport mthreadautodrawpackagemthread_drawadbtouchconsole scriptmthreadautodrawdesktop entry pointmthread-drawadbtouchmthread-drawAutoDraw-x.y.z-x64.msiMThreadDraw-x.y.z-x64.msiAutoDrawnamespace and assembly (WinUI)MThreadDrawcom.adbtouch(injector)com.mthreadAdbTouchErrorMThreadErrorADBTOUCH_CACHEMTHREAD_CACHEMAXAWER/AutoDraw-SimMAXAWER/MThread-DrawThe repository has already been renamed on GitHub; the old address redirects,
but local remotes want updating:
No compatibility shim, and none is owed: nothing was ever released under the old
names except a January pre-release of a different program, which is still on the
releases page and now labelled as such.
The product's name has a space wherever a person reads it — window title, Start
Menu entry, installer dialogs, prose — and none wherever a machine does. That
distinction is why the mechanical pass could not be the whole job, and the
second pass over display strings is the interesting part of this diff.
Two things found on the way
Renaming by rewriting text files is wrong on Windows. The first attempt read
each file as text and wrote it back, which flattened
run.bat's CRLF endings.The pass now works on bytes, sourced from the git index rather than the working
tree, so it changes names and nothing else.
run.bat's stored endings do changein this diff, but only because
.gitattributeshas asked foreol=crlfallalong while the blob was still CRLF — this normalises it.
run.batcould never have fetched adb. Two backslashes had been lost from itlong before today, so it looked for
platform-tools<BEL>db.exeand tried to runtools<FF>etch_platform_tools.py— a bell and a formfeed where\aand\fused to be. Both restored, which is an unrelated bug fix riding along in a
rename, and worth knowing about.
Verified
injector.jarrebuilt againstcom.mthread.autodraw,adbtouchorAdbTouchremains anywhere.Still to do, and not in this PR: adding the WinUI build to
release.yml, whichis the thing that has to land before v1.1.0 is worth cutting.
🤖 Generated with Claude Code