replace echo with printf for portable color output in Makefile#1
Open
Yin-SHT wants to merge 1 commit into
Open
replace echo with printf for portable color output in Makefile#1Yin-SHT wants to merge 1 commit into
Yin-SHT wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a portability issue with the Makefile that causes ANSI color codes to be displayed as raw text instead of colored output on various systems.
Problem
The current Makefile uses
echoto display colored build messages with ANSI escape sequences. However,echo's handling of escape sequences is inconsistent across different shells and platforms. On my system, the build output shows raw escape codes.Solution
Replaced all
echocommands withprintf, which consistently interprets escape sequences across all POSIX-compliant systems: