Skip to content

Enhance loadFile, navigateWindow binding, and window hints - #8

Merged
ClausValcaTD merged 1 commit into
mainfrom
feat/navigate-window-loadfile-hints-2189356032866860824
Sep 30, 2026
Merged

ClausValcaTD merged 1 commit into
mainfrom
feat/navigate-window-loadfile-hints-2189356032866860824

Conversation

@ClausValcaTD

Copy link
Copy Markdown
Contributor

Enhance loadFile with file:// URI support, add navigateWindow native C++ binding, and support BrowserWindow window size hints (resizable, minWidth, minHeight, maxWidth, maxHeight).


PR created automatically by Jules for task 2189356032866860824 started by @ClausValcaTD

… hints

- Implemented native navigateWindow(windowId, url) C++ binding.
- Updated BrowserWindow.loadFile to convert paths to file:// URLs using pathToFileURL for proper relative asset loading.
- Mapped resizable, minWidth, minHeight, maxWidth, and maxHeight options in BrowserWindow to webview.h hints.
- Added test/test_loadfile.js and updated test/test.js for integration testing.

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ClausValcaTD
ClausValcaTD merged commit 759819a into main Sep 30, 2026
1 check passed
@ClausValcaTD
ClausValcaTD deleted the feat/navigate-window-loadfile-hints-2189356032866860824 branch September 30, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant