Repository navigation
Fix OpenROM-bins Cloning, Remove Stale Commit Pin & Fix Working Directory Traversal - #142
Conversation
…ectory traversal Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses two issues with fetching
OpenROM-bins:586f7cc54df0facf9df9d3066c70e6b434b93753from.github/workflows/Release.ymland.github/workflows/Flatpak.yml, allowing the latestOpenROM-binsfrommain(includingchecksums.sha256and NKit 3.1.0 binaries) to be cloned.(cd bins && ...)in workflows andpushd bins/popdinbuild_windows.bat, ensuring downstream copy commands correctly resolve paths relative to the repository root.PR created automatically by Jules for task 14752942830787187812 started by @ClausValcaTD