Repository navigation
Catch unmapped platforms in CHD routing - #134
ClausValcaTD merged 2 commits into
Conversation
- Define explicit cdPlatforms and dvdPlatforms lists in converter.dart - Replace default createdvd fallback with strict platform check or media override - Raise error requiring --media cd or --media dvd for unmapped platforms - Add unit tests verifying unmapped platforms fail safely without --media Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Define explicit cdPlatforms and dvdPlatforms lists in converter.dart - Replace default createdvd fallback with strict platform check or media override - Raise error requiring --media cd or --media dvd for unmapped platforms - Add unit tests verifying unmapped platforms fail safely without --media Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
1 participant
Replaced silent fallback to createdvd in CHD routing with explicit lists (cdPlatforms, dvdPlatforms) and strict validation. If an unmapped platform name is provided without an explicit --media flag, conversion fails safely with an error requiring --media cd or --media dvd. Added unit tests verifying this behavior.
PR created automatically by Jules for task 13538680541611807538 started by @ClausValcaTD