Repository navigation
Fix UNKNOWN platform fallback & DAT index collisions - #133
Conversation
- Require --media cd|dvd or platform override when converting UNKNOWN images to CHD - Add interactive media choice dialog in GUI for UNKNOWN platform CHD jobs - Key DAT index with composite key crc32_size and validate size on lookups - Add unit tests for unknown platform routing safety and composite DAT lookups Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Require --media cd|dvd or platform override when converting UNKNOWN images to CHD - Add interactive media choice dialog in GUI for UNKNOWN platform CHD jobs - Key DAT index with composite key crc32_size and validate size on lookups - Add unit tests for unknown platform routing safety and composite DAT lookups Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
- Require --media cd|dvd or platform override when converting UNKNOWN images to CHD - Add interactive media choice dialog in GUI for UNKNOWN platform CHD jobs - Key DAT index with composite key crc32_size and validate size on lookups - Add unit tests for unknown platform routing safety and composite DAT lookups Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
1 participant
Enforce safe routing for UNKNOWN platform images when converting to CHD by requiring explicit --media cd|dvd flag or platform override, prompt user in GUI, and update DAT index to use composite keys (crc32_size) with file size validation.
PR created automatically by Jules for task 5816947178542638014 started by @ClausValcaTD