ci: align formatter and quality gate toolchains

.github/workflows/auto_fix.yml

@@ -16,17 +16,20 @@ jobs:
       - name: Setup Flutter
         uses: subosito/flutter-action@v2
         with:
-          channel: 'stable'
+          flutter-version: '3.47.6'
+          cache: true
 
       - name: Auto-Format Dart
         run: |
           if [ -d "gui" ]; then
             cd gui
+            flutter pub get
             dart format .
             cd ..
           fi
           if [ -d "core" ]; then
             cd core
+            dart pub get
             dart format .
             cd ..
           fi

.github/workflows/quality.yml

@@ -29,7 +29,7 @@ jobs:
       - name: Set up Flutter
         uses: subosito/flutter-action@v2
         with:
-          channel: stable
+          flutter-version: '3.47.6'
           cache: true
 
       - name: Install GUI dependencies

core/bin/openrom.dart

@@ -355,8 +355,7 @@ int main(List<String> args) {
 
   if ((results['m3u'] as List<String>).isNotEmpty) {
     final discFiles = results['m3u'] as List<String>;
-    final out =
-        results['output'] as String? ??
+    final out = results['output'] as String? ??
         p.dirname(p.canonicalize(discFiles.first));
     final rel = results['absolute'] != true;
     try {
@@ -714,9 +713,8 @@ int main(List<String> args) {
     var fields = readIpbin(file);
     if (results['set-title'] != null) {
       final title = results['set-title'] as String;
-      fields['product_name'] = title.length > 16
-          ? title.substring(0, 16)
-          : title;
+      fields['product_name'] =
+          title.length > 16 ? title.substring(0, 16) : title;
       fields['product_name_2'] = title.length > 16
           ? title.substring(16, title.length > 32 ? 32 : title.length)
           : '';

core/lib/src/bin_merger.dart

@@ -120,9 +120,8 @@ BinMergeResult mergeBins(
   }
 
   final cueDir = p.dirname(p.canonicalize(cuePath));
-  final targetDir = (outputDir != null && outputDir.isNotEmpty)
-      ? outputDir
-      : cueDir;
+  final targetDir =
+      (outputDir != null && outputDir.isNotEmpty) ? outputDir : cueDir;
   Directory(targetDir).createSync(recursive: true);
 
   final tracks = parseCue(cuePath);
@@ -182,9 +181,8 @@ BinMergeResult mergeBins(
             break;
           }
         }
-        final idx01Offset = idx01Entry != null
-            ? _msfToSectors(idx01Entry.msf)
-            : 0;
+        final idx01Offset =
+            idx01Entry != null ? _msfToSectors(idx01Entry.msf) : 0;
 
         computedIndexes = [];
         for (final idxItem in parsedIndexes) {

core/lib/src/compressor.dart

@@ -37,8 +37,8 @@ class CompressionJob {
     this.status = 'Queued',
     this.progress = 0.0,
     this.error,
-  }) : format = format.toLowerCase(),
-       level = level.toLowerCase();
+  })  : format = format.toLowerCase(),
+        level = level.toLowerCase();
 }
 
 class Compressor {

core/lib/src/config.dart

@@ -11,8 +11,7 @@ const String appName = 'OpenROM';
 String getDirectoryConfig() {
   String path;
   if (Platform.isWindows) {
-    final base =
-        Platform.environment['APPDATA'] ??
+    final base = Platform.environment['APPDATA'] ??
         Platform.environment['USERPROFILE'] ??
         '';
     path = p.join(base, appName);
@@ -64,8 +63,8 @@ String getDefaultBundledPath(String tool) {
   }
 
   final String archFolder;
-  final archStr = '${Platform.version} ${Platform.operatingSystem}'
-      .toLowerCase();
+  final archStr =
+      '${Platform.version} ${Platform.operatingSystem}'.toLowerCase();
   if (archStr.contains('aarch64') || archStr.contains('arm64')) {
     archFolder = 'arm64';
   } else {
@@ -136,9 +135,8 @@ String getDefaultBundledPath(String tool) {
     return bundled;
   }
 
-  final fallback = Platform.isWindows
-      ? (winNames[tool] ?? tool)
-      : (unixNames[tool] ?? tool);
+  final fallback =
+      Platform.isWindows ? (winNames[tool] ?? tool) : (unixNames[tool] ?? tool);
   ensureExecutable(fallback);
   return fallback;
 }

core/lib/src/converter.dart

@@ -59,8 +59,8 @@ class ConversionJob {
     List<String>? logLines,
     this.error,
     List<String>? tempFiles,
-  }) : logLines = logLines ?? [],
-       tempFiles = tempFiles ?? [];
+  })  : logLines = logLines ?? [],
+        tempFiles = tempFiles ?? [];
 
   Map<String, dynamic> getFileInfo() {
     if (_fileInfo == null) {
@@ -135,8 +135,7 @@ class Converter {
 
     final valid = detector.getValidTargets(fmt);
     if (!valid.contains(tgt) && tgt != 'BIN/CUE' && tgt != 'FILES') {
-      final err =
-          'Cannot convert $fmt → $tgt. '
+      final err = 'Cannot convert $fmt → $tgt. '
           'Supported targets for $fmt: ${valid.isNotEmpty ? valid.join(', ') : 'none'}';
       _log('[ERROR] $err');
       job.error = err;
@@ -215,9 +214,8 @@ class Converter {
       subCmd = 'createcd';
     }
 
-    final compressionMap = subCmd == 'createcd'
-        ? chdCdCompression
-        : chdDvdCompression;
+    final compressionMap =
+        subCmd == 'createcd' ? chdCdCompression : chdDvdCompression;
     final defaultCodec = subCmd == 'createcd' ? 'cdlz' : 'zlib';
     final cmd = [
       chdman,
@@ -396,8 +394,7 @@ class Converter {
 
   bool _xboxConvert(ConversionJob job, String src, String fmt) {
     if (Platform.isMacOS) {
-      job.error =
-          'Xbox format conversion is not supported on macOS. '
+      job.error = 'Xbox format conversion is not supported on macOS. '
           'XGDTool does not currently provide a macOS build.';
       _log('  ❌ ${job.error}');
       return false;

core/lib/src/dcp_patcher.dart

@@ -184,9 +184,8 @@ class DcpPatcher {
       final basePath = p.normalize(p.canonicalize(outputDir));
 
       for (final entry in xdeltaEntries) {
-        final archivePrefix = entry.name.startsWith('xdelta\\')
-            ? 'xdelta\\'
-            : 'xdelta/';
+        final archivePrefix =
+            entry.name.startsWith('xdelta\\') ? 'xdelta\\' : 'xdelta/';
         final relativePatchName = entry.name.substring(archivePrefix.length);
         String targetName = relativePatchName.replaceAll('\\', '/');
 

core/lib/src/gdi_reader.dart

@@ -44,10 +44,8 @@ List<GdiTrack> parseGdi(String gdiPath) {
   final gdiDir = p.dirname(p.canonicalize(gdiPath));
   final tracks = <GdiTrack>[];
 
-  final lines = file
-      .readAsLinesSync()
-      .where((l) => l.trim().isNotEmpty)
-      .toList();
+  final lines =
+      file.readAsLinesSync().where((l) => l.trim().isNotEmpty).toList();
   if (lines.isEmpty) return tracks;
 
   for (final line in lines.skip(1)) {
@@ -64,9 +62,8 @@ List<GdiTrack> parseGdi(String gdiPath) {
         filename = filename.substring(1, filename.length - 1);
       }
       final filepath = p.join(gdiDir, filename);
-      final filesize = File(filepath).existsSync()
-          ? File(filepath).lengthSync()
-          : 0;
+      final filesize =
+          File(filepath).existsSync() ? File(filepath).lengthSync() : 0;
 
       tracks.add(
         GdiTrack(

core/lib/src/header_remover.dart

@@ -94,9 +94,8 @@ Map<String, dynamic>? detectHeader(String filepath) {
 
       final hasCopierHeaderInternal =
           _verifySnesInternalHeader(headerData, 0x81C0) ||
-          _verifySnesInternalHeader(headerData, 0x101C0);
-      final hasCleanInternal =
-          _verifySnesInternalHeader(headerData, 0x7FC0) ||
+              _verifySnesInternalHeader(headerData, 0x101C0);
+      final hasCleanInternal = _verifySnesInternalHeader(headerData, 0x7FC0) ||
           _verifySnesInternalHeader(headerData, 0xFFC0);
 
       if (hasCopierHeaderInternal) {

core/lib/src/m3u_generator.dart

@@ -20,8 +20,7 @@ String generateM3u({
     }
   }
 
-  final targetDir =
-      Directory(outputPath).existsSync() ||
+  final targetDir = Directory(outputPath).existsSync() ||
           !outputPath.toLowerCase().endsWith('.m3u')
       ? outputPath
       : p.dirname(outputPath);

core/lib/src/rom_renamer.dart

@@ -164,10 +164,8 @@ String calcCrc32(String filepath, {void Function(double pct)? onProgress}) {
     raf.closeSync();
   }
 
-  final hex = (crc & 0xFFFFFFFF)
-      .toRadixString(16)
-      .toLowerCase()
-      .padLeft(8, '0');
+  final hex =
+      (crc & 0xFFFFFFFF).toRadixString(16).toLowerCase().padLeft(8, '0');
   return hex;
 }
 
@@ -216,9 +214,8 @@ Map<String, Map<String, dynamic>> loadDatIndex(String datPath) {
         if (crc.isNotEmpty) {
           index[crc] = {
             'name': currentGameName,
-            'description': currentDesc.isNotEmpty
-                ? currentDesc
-                : currentGameName,
+            'description':
+                currentDesc.isNotEmpty ? currentDesc : currentGameName,
             'rom_name': romName,
             'size': size,
             'md5': md5,

core/test/dcp_builder_test.dart

@@ -91,14 +91,14 @@ void main() {
 
     expect(result['success'], isTrue);
 
-    final patchedIpBin = File(p.join(outputDir.path, 'IP.BIN'))
-        .readAsStringSync();
-    final patched1stRead = File(p.join(outputDir.path, '1ST_READ.BIN'))
-        .readAsStringSync();
-    final patchedConfig = File(p.join(outputDir.path, 'DATA', 'CONFIG.TXT'))
-        .readAsStringSync();
-    final patchedNewFile = File(p.join(outputDir.path, 'DATA', 'NEWFILE.BIN'))
-        .readAsStringSync();
+    final patchedIpBin =
+        File(p.join(outputDir.path, 'IP.BIN')).readAsStringSync();
+    final patched1stRead =
+        File(p.join(outputDir.path, '1ST_READ.BIN')).readAsStringSync();
+    final patchedConfig =
+        File(p.join(outputDir.path, 'DATA', 'CONFIG.TXT')).readAsStringSync();
+    final patchedNewFile =
+        File(p.join(outputDir.path, 'DATA', 'NEWFILE.BIN')).readAsStringSync();
 
     expect(patchedIpBin, equals('MODIFIED_BOOTSECTOR_IPBIN_HEADER_67890'));
     expect(patched1stRead, equals('MODIFIED_GAME_CODE_XYZ123'));

core/test/ssp_builder_test.dart

@@ -38,8 +38,7 @@ void main() {
       ecc.recalculateSector(sector);
 
       // Verify EDC non-zero
-      final edcVal =
-          sector[0x810] |
+      final edcVal = sector[0x810] |
           (sector[0x811] << 8) |
           (sector[0x812] << 16) |
           (sector[0x813] << 24);
@@ -113,10 +112,8 @@ void main() {
         final changesTxt = utf8.decode(changesFile.content as List<int>);
 
         final origIsoContent = Iso9660Reader.readIsoFile(origBin, 18, 39);
-        final expectedMd5 = md5
-            .convert(origIsoContent)
-            .toString()
-            .toUpperCase();
+        final expectedMd5 =
+            md5.convert(origIsoContent).toString().toUpperCase();
 
         expect(changesTxt, contains('TEST.BIN: $expectedMd5'));
 
@@ -126,7 +123,9 @@ void main() {
       },
     );
 
-    test('SspBuilder generated SSP can be applied with saturn-patcher CLI binary if available', () async {
+    test(
+        'SspBuilder generated SSP can be applied with saturn-patcher CLI binary if available',
+        () async {
       final builder = SspBuilder(
         originalBin: origBin,
         modifiedBin: modBin,

gui/analysis_options.yaml

@@ -7,6 +7,12 @@
 
 # The following line activates a set of recommended lints for Flutter apps,
 # packages, and plugins designed to encourage good coding practices.
+analyzer:
+  exclude:
+    - build/**
+    - windows/**
+    - macos/**
+    - linux/**
 include: package:flutter_lints/flutter.yaml
 
 linter:

gui/lib/l10n/app_localizations.dart

@@ -72,7 +72,7 @@ import 'app_localizations_zh.dart';
 /// property.
 abstract class AppLocalizations {
   AppLocalizations(String locale)
-    : localeName = intl.Intl.canonicalizedLocale(locale.toString());
+      : localeName = intl.Intl.canonicalizedLocale(locale.toString());
 
   final String localeName;
 
@@ -95,11 +95,11 @@ abstract class AppLocalizations {
   /// of delegates is preferred or required.
   static const List<LocalizationsDelegate<dynamic>> localizationsDelegates =
       <LocalizationsDelegate<dynamic>>[
-        delegate,
-        GlobalMaterialLocalizations.delegate,
-        GlobalCupertinoLocalizations.delegate,
-        GlobalWidgetsLocalizations.delegate,
-      ];
+    delegate,
+    GlobalMaterialLocalizations.delegate,
+    GlobalCupertinoLocalizations.delegate,
+    GlobalWidgetsLocalizations.delegate,
+  ];
 
   /// A list of this localizations delegate's supported locales.
   static const List<Locale> supportedLocales = <Locale>[
@@ -113,7 +113,7 @@ abstract class AppLocalizations {
     Locale('pt'),
     Locale('ru'),
     Locale('tr'),
-    Locale('zh'),
+    Locale('zh')
   ];
 
   /// No description provided for @appTitle.
@@ -878,18 +878,18 @@ class _AppLocalizationsDelegate
 
   @override
   bool isSupported(Locale locale) => <String>[
-    'ar',
-    'de',
-    'en',
-    'es',
-    'fr',
-    'it',
-    'ja',
-    'pt',
-    'ru',
-    'tr',
-    'zh',
-  ].contains(locale.languageCode);
+        'ar',
+        'de',
+        'en',
+        'es',
+        'fr',
+        'it',
+        'ja',
+        'pt',
+        'ru',
+        'tr',
+        'zh'
+      ].contains(locale.languageCode);
 
   @override
   bool shouldReload(_AppLocalizationsDelegate old) => false;
@@ -923,9 +923,8 @@ AppLocalizations lookupAppLocalizations(Locale locale) {
   }
 
   throw FlutterError(
-    'AppLocalizations.delegate failed to load unsupported locale "$locale". This is likely '
-    'an issue with the localizations generation tool. Please file an issue '
-    'on GitHub with a reproducible sample app and the gen-l10n configuration '
-    'that was used.',
-  );
+      'AppLocalizations.delegate failed to load unsupported locale "$locale". This is likely '
+      'an issue with the localizations generation tool. Please file an issue '
+      'on GitHub with a reproducible sample app and the gen-l10n configuration '
+      'that was used.');
 }