fix(android): respect android.builtInKotlin flag when applying Kotlin plugin - #1100
Merged
Merged
Conversation
… plugin
The plugin gated the standalone Kotlin Gradle plugin purely on the AGP
major version (`agpMajor < 9`), assuming AGP 9 always implies built-in
Kotlin. But built-in Kotlin can be disabled on AGP 9 via the
`android.builtInKotlin` Gradle property. When it is off, neither KGP nor
built-in Kotlin is applied, leaving the `kotlin { }` block with no
backing extension and failing the build.
Check the flag in addition to the AGP version so the standalone plugin
is applied whenever built-in Kotlin is not active. Mirrors the logic
used by other Flutter plugins (e.g. file_picker).
Lyokone
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… plugin
The plugin gated the standalone Kotlin Gradle plugin purely on the AGP major version (
agpMajor < 9), assuming AGP 9 always implies built-in Kotlin. But built-in Kotlin can be disabled on AGP 9 via theandroid.builtInKotlinGradle property. When it is off, neither KGP nor built-in Kotlin is applied, leaving thekotlin { }block with no backing extension and failing the build.Check the flag in addition to the AGP version so the standalone plugin is applied whenever built-in Kotlin is not active. Mirrors the logic used by other Flutter plugins (e.g. file_picker).