fix(server): preserve UTF-8 across stream boundaries - #580
Open
Amidwestnoob wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Amidwestnoob
force-pushed
the
fix/utf8-stream-boundary
branch
from
August 5, 2026 12:25
d74db44 to
e6ae9ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_calls; report capped output aslength/max_tokens.Problem
The emitter sanitized each token fragment independently. A valid multibyte code point split across fragments could therefore become replacement characters. Finish-reason derivation also differed between API responses and the final server log.
Validation
dflash_serverbuild passed.café — π ∈ ∅ ⊆and∀∃∈∅⊆⊇∩≠→in layer and tensor modes.length.tool_calls.Patch SHA-256:
1c7b29b1fee3db63e52b696bc7e8812110f396feb1fd2b09ffa614a69a0470dbScope
This patch changes stream assembly and finish-reason reporting only. It does not change tensor-parallel math, speculative decoding, model loading, draft compatibility, or production configuration.