fix: whitespace-only .gitignore lines no longer match every file - #3462
Open
cpruijsen wants to merge 2 commits into
Open
fix: whitespace-only .gitignore lines no longer match every file#3462cpruijsen wants to merge 2 commits into
cpruijsen wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Notice: It looks like you're using hustcer/deepseek-review, but the CHAT_TOKEN hasn't been configured in your repo's Variables/Secrets. Please ensure this token is set for proper functionality. For step-by-step guidance, refer to the CHAT_TOKEN Config section of README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
.gitignoreline holding only whitespace made the whole workspace disappear from the languageserver. Git treats such a line as blank and skips it, so the file looks harmless in review, and the
symptom is that every file in the project silently stops resolving.
mt:patterninscript/glob/matcher.luareadstate[1]without checking it was there. Awhitespace-only line leaves the state empty, the pattern compiles to something that matches
everything, and the matcher then ignores the workspace root. This returns
nilfor that stateinstead, which is how the caller already represents "this line contributes no pattern", so the line
is skipped exactly as git skips it.
Changelog entry included, per the repo convention of adding one under Unreleased.
Fixes #3458