Add color pickers to the color options in settings#694
Open
radther wants to merge 12 commits intoLoveRetro:mainfrom
Open
Add color pickers to the color options in settings#694radther wants to merge 12 commits intoLoveRetro:mainfrom
radther wants to merge 12 commits intoLoveRetro:mainfrom
Conversation
- Keep color_picker's factory helper lambdas and g_colorDefs approach - Use COLOR_BACKGROUND named constant instead of magic number 7 - Use GFX_clearLayers(LAYER_BACKGROUND) for bg fill (uses vid.clear_color) - Background color already present in g_colorDefs, main's inline entry discarded Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds color pickers to all the color options in the settings tool. The picker features RGB sliders, quick select of other colors, a preview window, and live updating of colors.
Why
Allows for more customisation theming without needing background images. The color can be combined with the other colors for fun themes.
How