Skip to content

sd: fix: inhibit ggml log changes from sdcpp code - #2483

Open
wbruna wants to merge 2 commits into
LostRuins:concedo_experimentalfrom
wbruna:kcpp_sd_inhibit_ggml_log
Open

wbruna wants to merge 2 commits into
LostRuins:concedo_experimentalfrom
wbruna:kcpp_sd_inhibit_ggml_log

Conversation

@wbruna

@wbruna wbruna commented Sep 19, 2026

Copy link
Copy Markdown

No description provided.

@wbruna

wbruna commented Sep 19, 2026

Copy link
Copy Markdown
Author

This is missing a sdcpp_logger_adapter cleanup; it's not clear to me if that module would still be useful.

@LostRuins

Copy link
Copy Markdown
Owner

This is missing a sdcpp_logger_adapter cleanup; it's not clear to me if that module would still be useful.

tbh we can get rid of it but if we do so we just have to patch the native sd logger for the string format reasons i mentioned earlier in discord

@wbruna

wbruna commented Sep 20, 2026

Copy link
Copy Markdown
Author

Sent it upstream: leejet/stable-diffusion.cpp#2002

But there is also the threading issue: log_printf uses a static buffer. That's not exactly comfortable for ggml logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants