Keep the main performance channel on the .NET 11 SDK - #5
Draft
LoopedBard3 wants to merge 1 commit into
Draft
LoopedBard3 wants to merge 1 commit into
LoopedBard3 wants to merge 1 commit into
Conversation
Avoid generating net12.0 benchmark projects with an SDK that still supports only net11.0 targeting. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change only
scripts/channel_map.pysomain.branchselects11.0instead of12.0, partially reverting dotnet#5299. Keep thenet11.0TFM, .NET 12 NuGet feeds, and explicit .NET 11 channel mappings unchanged.Why
The early .NET 12 SDK runs the BenchmarkDotNet host on .NET 12 but still supports targeting only through
net11.0. BDN's CoreRun toolchain derives its generated target framework from the host runtime, so it generatesnet12.0projects that fail withNETSDK1045.The runtime performance pipeline selects and pins the SDK during setup, then passes its exact version to Helix. Changing only the TFM-to-channel reverse lookup would not fix that path; rolling back the
mainSDK channel does.Validation
11.0fornet11.0, and that all other mappings remain unchanged.onlySanityCheck=true, using this exact fix commit (404aa6a669466c71cb7070f688adcda46593d63d).11.0.100-rc.2.26460.105, successfully restored/published the BDN-generatednet11.0project, and executed 35 benchmarks with real measurements and noNETSDK1045. The second Windows x64 leg also executed 35 benchmarks; Windows x86 passed.12.0.0-ci, while the selected installation contains12.0.0-alpha.1.26458.117, causingMSB6006/NETSDK1144. Neither is the original CoreRunNETSDK1045failure.