Skip to content

Test: Do not accept an engine error as a streamed reply #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-re-w merged 1 commit into from
Oct 3, 2026
Merged

Test: Do not accept an engine error as a streamed reply #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion api/tests/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,10 @@ def test_streams_tokens_then_eos(client):
break
ws.__exit__(None, None, None)

reply = "".join(frames[:-1])
assert frames[-1] == "<EOS>"
assert "".join(frames[:-1]).strip()
assert reply.strip()
assert "ERROR:" not in reply, reply # an engine failure arrives as an ERROR message, not as a reply


def test_disconnect_mid_stream_stops_generation_and_frees_the_model(client, engine, monkeypatch):
Expand Down
Loading