Repository navigation
Chore: Run the API tests on torchnative in CI, with capability skips - #141
Merged
Merged
Conversation
A torchnative-tests workflow installs the torchnative extra (version as an input) and runs the full api/tests, real-model tests included, with skip reasons printed. It is non-blocking. Tests that need a capability the installed torchnative lacks skip with a reason naming it: needs_batching (engine.batching is False) and needs_quantization (q8_0 not offered by torchnative.quant). On upstream PyTorch nothing skips, which test_substrate.py guards. test_quantization.py adds q8_0 engine tests that run only on torchnative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#140, preparing #84 / M2 verification.
conftest.py: substrate detection (torchnative registers atorchdist; atorchnativedist means torchnative); markersneeds_batching,needs_quantization(skip only on torchnative, reason names the capability and version),torchnative_only(deselected on upstream).test_batching.py→needs_batching; newtest_quantization.py(q8_0 engine, torchnative only); newtest_substrate.pyguards that nothing skips on upstream..github/workflows/torchnative-tests.yml:workflow_dispatch(version input) + weekly schedule (both need the file on main) +pushtoci/torchnativefor on-demand runs;continue-on-error, not on PRs.Dry run on torchnative 0.1.0b4 (no model run):
TorchnativeConfig("q8_0")exists; the CB manager constructs on a tiny random config; whether warmup and real generation work is what this workflow's first run (on this branch) shows.Closes #140