Skip to content

[Fix] test_streams_tokens_then_eos passes when the engine fails #146

Closed

Description

@b-re-w

On torchnative 0.1.0b4 with mps (#84) every engine test failed, but test_server.py::test_streams_tokens_then_eos passed: BaseModel.chat turns an engine exception into an ERROR: message frame, and the test only checks that some text arrived before <EOS>.

Done when: the test fails if the streamed text is an error message (asserted by checking it does not contain the chat error marker), and passes on a working engine.

Activity

  1. b-re-w commented on Oct 3, 2026

    @b-re-w
    MemberAuthor

    Landed in develop via #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions