🛡️ Sentinel: [HIGH] Fix Login CSRF vulnerability in demo login endpoints - #720
🛡️ Sentinel: [HIGH] Fix Login CSRF vulnerability in demo login endpoints#720pboachie wants to merge 1 commit into
Conversation
…ulnerabilities. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🚨 Severity: HIGH
💡 Vulnerability: The
demo_loginanddemo_portal_loginendpoints inapps/auth_app/views.pywere decorated with@csrf_exempt, bypassing Django's built-in CSRF protection. This made the application vulnerable to Login CSRF, where an attacker could force a victim's browser to authenticate as a demo user (an attacker-controlled context), potentially leading to information disclosure or tricking the victim into performing actions within the demo session that they believe are their own.🎯 Impact: High potential for abuse as it involves authentication boundaries. Even though these are demo endpoints, they should adhere to standard security practices and not allow forced logins.
🔧 Fix: Removed the
@csrf_exemptdecorators from bothdemo_loginanddemo_portal_login. Removed the unusedcsrf_exemptimport. Frontend templates (templates/auth/login.html) already properly sent{% csrf_token %}, so native Django CSRF middleware now correctly protects these routes.✅ Verification: Ran
python3 -m pytest tests/test_auth_views.py -k "demo"locally and all 10 tests passed successfully, proving that normal demo login functionality works and is not disrupted by the added security constraint.PR created automatically by Jules for task 4013158564747416275 started by @pboachie