Skip to content

feat(web): Add session management UI for viewing and disconnecting active streams#5137

Open
numselli wants to merge 7 commits into
LizardByte:masterfrom
numselli:pr-4582
Open

feat(web): Add session management UI for viewing and disconnecting active streams#5137
numselli wants to merge 7 commits into
LizardByte:masterfrom
numselli:pr-4582

address comments

71bb435
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 6, 2026 in 1m 27s

Quality Gate failed

Failed conditions
10 New issues
9 New Code Smells (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 2121 in src/stream.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vHE55rYU4SfkTDZ&open=AZ405vHE55rYU4SfkTDZ&pullRequest=5137

Check failure on line 2175 in src/stream.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vHE55rYU4SfkTDf&open=AZ405vHE55rYU4SfkTDf&pullRequest=5137

Check warning on line 4 in src_assets/common/assets/web/sessions.html

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a <title> tag to this page.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vMv55rYU4SfkTDh&open=AZ405vMv55rYU4SfkTDh&pullRequest=5137

Check warning on line 2161 in src/stream.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vHE55rYU4SfkTDd&open=AZ405vHE55rYU4SfkTDd&pullRequest=5137

Check warning on line 27 in src_assets/common/assets/web/sessions.html

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use <output> instead of the status role to ensure accessibility across all devices.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vMv55rYU4SfkTDi&open=AZ405vMv55rYU4SfkTDi&pullRequest=5137

Check warning on line 2172 in src/stream.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "std::lock_guard" with "std::scoped_lock"

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vHE55rYU4SfkTDe&open=AZ405vHE55rYU4SfkTDe&pullRequest=5137

Check failure on line 2108 in src/stream.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vHE55rYU4SfkTDb&open=AZ405vHE55rYU4SfkTDb&pullRequest=5137

Check warning on line 2112 in src/stream.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a global variable "info" in the outer scope.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vHE55rYU4SfkTDc&open=AZ405vHE55rYU4SfkTDc&pullRequest=5137

Check warning on line 1070 in src/confighttp.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one.

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vLw55rYU4SfkTDg&open=AZ405vLw55rYU4SfkTDg&pullRequest=5137

Check warning on line 2106 in src/stream.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "std::lock_guard" with "std::scoped_lock"

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ405vHE55rYU4SfkTDa&open=AZ405vHE55rYU4SfkTDa&pullRequest=5137