Skip to content

LF-5388(1): Address remaining certification TODOs#4263

Merged
SayakaOno merged 5 commits into
integrationfrom
LF-5388/Address_remaining_certification_TODOs
Jul 16, 2026
Merged

LF-5388(1): Address remaining certification TODOs#4263
SayakaOno merged 5 commits into
integrationfrom
LF-5388/Address_remaining_certification_TODOs

Conversation

@SayakaOno

@SayakaOno SayakaOno commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Display loading view when fetching certifications
  • Handle isLoading while adding/editing/deleting certifications
  • Add success snackbars for adding/editing/deleting certifications
  • Preserve original file name
  • Fix document preview for private bucket storage

Jira link: https://lite-farm.atlassian.net/browse/LF-5388

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno self-assigned this Jul 16, 2026
@SayakaOno SayakaOno added enhancement New feature or request new translations New translations to be sent to CrowdIn are present labels Jul 16, 2026
SayakaOno and others added 2 commits July 16, 2026 16:32
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@SayakaOno
SayakaOno force-pushed the LF-5388/Address_remaining_certification_TODOs branch from b4b5bf5 to 1c21fd3 Compare July 16, 2026 23:33
@SayakaOno
SayakaOno marked this pull request as ready for review July 16, 2026 23:33
@SayakaOno
SayakaOno requested review from a team as code owners July 16, 2026 23:33
@SayakaOno
SayakaOno requested review from kathyavini and removed request for a team July 16, 2026 23:33
@SayakaOno
SayakaOno added this pull request to the merge queue Jul 16, 2026
@SayakaOno

Copy link
Copy Markdown
Collaborator Author

Merged without review since we only have one dev this week.

Merged via the queue into integration with commit 274a957 Jul 16, 2026
4 checks passed
@SayakaOno
SayakaOno deleted the LF-5388/Address_remaining_certification_TODOs branch July 16, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new translations New translations to be sent to CrowdIn are present

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant