Skip to content

LF-5390(2): Certifications Bug fix#4262

Merged
SayakaOno merged 2 commits into
integrationfrom
LF-5390_2/Bug_fix
Jul 16, 2026
Merged

LF-5390(2): Certifications Bug fix#4262
SayakaOno merged 2 commits into
integrationfrom
LF-5390_2/Bug_fix

Conversation

@SayakaOno

Copy link
Copy Markdown
Collaborator

Description

  • Update FormNavigationButtons component to add type="button" to the "Cancel" and "Previous" buttons so they don't unexpectedly submit the form inside <form />.
  • Update getCertifierKey so the same other_certifier with different system types gets unique keys.

Jira link: https://lite-farm.atlassian.net/browse/LF-5390

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno self-assigned this Jul 16, 2026
@SayakaOno
SayakaOno requested review from a team as code owners July 16, 2026 20:46
@SayakaOno SayakaOno added the bug Something isn't working label Jul 16, 2026
@SayakaOno
SayakaOno requested review from kathyavini and removed request for a team July 16, 2026 20:46
@SayakaOno
SayakaOno added this pull request to the merge queue Jul 16, 2026
Merged via the queue into integration with commit 7eb6ef6 Jul 16, 2026
6 checks passed
@SayakaOno
SayakaOno deleted the LF-5390_2/Bug_fix branch July 16, 2026 20:50
@SayakaOno

Copy link
Copy Markdown
Collaborator Author

Merged without review since we only have one dev this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant