Skip to content

feat(mainpage): automate 'in memory of' display in mainpages #6943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ElectricalBoy wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(mainpage): automate 'in memory of' display in mainpages #6943

ElectricalBoy wants to merge 8 commits into from
+42 −3

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Jan 2, 2026 •
edited
Loading

Summary

Depends on #6946

This PR automates use of #5569 in main pages.

How did you test this change?

https://liquipedia.net/leagueoflegends/User:ElectricalBoy/MainPage (dev uses 4 week offset for testing purposes instead of 2 weeks as specified in this PR)

hjpalpha
hjpalpha reviewed Jan 2, 2026
View reviewed changes
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw when rolling this out we need to check if there is some usage of the current inmemory stuff so we do not double display banners

lua/wikis/commons/MainPageLayout.lua Outdated
conditions = tostring(ConditionTree(BooleanOperator.all):add{
ConditionNode(ColumnName('deathdate'), Comparator.neq, DateExt.defaultDate),
ConditionNode(ColumnName('deathdate'), Comparator.ge, DateExt.toYmdInUtc(
DateExt.getCurrentTimestamp() - 1209600 --[[2 weeks]]
Copy link
Collaborator

@hjpalpha hjpalpha Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the number into a const var

Copy link
Collaborator Author

@ElectricalBoy ElectricalBoy Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6946

@ElectricalBoy ElectricalBoy force-pushed the mainpage-automate-in-memory-of branch from 4da64fb to 43e4b93 Compare January 2, 2026 06:32
@ElectricalBoy ElectricalBoy requested a review from hjpalpha January 2, 2026 06:33
@ElectricalBoy ElectricalBoy changed the base branch from main to days-to-seconds January 2, 2026 06:33
@ElectricalBoy ElectricalBoy force-pushed the mainpage-automate-in-memory-of branch 2 times, most recently from 34aae25 to c8811ab Compare January 19, 2026 00:57
Base automatically changed from days-to-seconds to main January 19, 2026 11:15
@mbergen
Copy link
Collaborator

mbergen commented Jan 28, 2026

Since this would be a highly delicate display, we probably want some sort of confirmation time or manual step involved, to avoid vandalism on a player page to immediately show on the main page.

@ElectricalBoy ElectricalBoy force-pushed the mainpage-automate-in-memory-of branch from c8811ab to 41b9d78 Compare January 30, 2026 07:54
@ElectricalBoy
Copy link
Collaborator Author

ElectricalBoy commented Jan 30, 2026

Since this would be a highly delicate display, we probably want some sort of confirmation time or manual step involved, to avoid vandalism on a player page to immediately show on the main page.

yeah that actually is a good point
maybe enforce list of player pages to be inputted and automate removal?

@ElectricalBoy ElectricalBoy requested a review from a team January 30, 2026 08:04
@mbergen
Copy link
Collaborator

mbergen commented Jan 30, 2026

Since this would be a highly delicate display, we probably want some sort of confirmation time or manual step involved, to avoid vandalism on a player page to immediately show on the main page.

yeah that actually is a good point maybe enforce list of player pages to be inputted and automate removal?

Seems like a decent way to go.

mbergen
mbergen approved these changes Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@mbergen mbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbergen mbergen mbergen approved these changes

@hjpalpha hjpalpha hjpalpha approved these changes

@Eetwalt Eetwalt Eetwalt approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c: main_page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ElectricalBoy @mbergen @hjpalpha @Eetwalt