Repository navigation
Name-lookup test counts only its own game's lookups - #155
Merged
Merged
Conversation
The scan also reads the real Steam install on the machine running the test, and looks up any game there the offline dictionary lacks. Every lookup was counted, so the test failed on a PC with such a game installed: two lookups on the first scan, and a third on the second, since a name that is not found is not cached. The count now covers only the test's own game, and is atomic, as lookups run concurrently.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestResolveNames_UsesResolverAndCachesResultfailed on any PC with a Steam game installed that the offline name dictionary doesn't know. CI has no Steam, so it passed there.Why: the scan also reads the real Steam install on the machine running the test, since the registry isn't isolated, and looks up names for unknown games there too. The test counted every lookup:
Fix: count only lookups for the test's own game, with an atomic counter, as lookups run concurrently. Test-only, no code change.
Testing: the test passes 5 times in a row on a PC where it failed every time before, and
go test ./internal/presetspasses.