Repository navigation
A sync that did not reach a device is no longer called in sync - #154
Merged
Merged
Conversation
The CLI and the Deck plugin read a sync's answer per device, and any status they did not know counted as in sync: another device playing the game, with syncing paused, a save folder here that could not be written, or a sync with a device that failed. So "already in sync" was said of a save that had not gone over, and at a launch the Deck started the game quietly on the save it had while the game was being played on the PC. Each of those is now said for what it is. A failed sync with a device is a failure; a status not known here is shown rather than read as in sync. The Deck says it at a launch too. docs/CLI.md also covers the commands added since it was last written: pause, resume, transfers, activity, sessions, rename, offers, peers trust, emptied, relocate, storage and verify.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI and the Deck plugin both summarise a sync by reading what happened with each device. Any status they didn't know counted as in sync:
peer_playingpeer_pausedunwritableerrorSo
opensave synccould say "already in sync" about a save that hadn't gone over. On the Deck it was worse: at a launch, a game being played on the PC came back as in sync, and the Deck started it quietly on the save it had.Now
opensave activity, and the Deck reports an error.opensave sync <game>no longer says "Synced … with the devices that could take it" when no device took it.docs/CLI.md hadn't changed since September. It now covers
pause,resume,transfers,activity,sessions,rename,offers,peers trust,emptied,relocate,storageandverify, and lists which of them need a daemon.Testing
TestSyncOutcomes(CLI) and in the plugin'stest_main.py, covering each status, a mix of devices, and an unknown status.go test ./internal/cliapp ./internal/api(incl.TestDeckyPluginContract), the CLI e2e tests, the plugin's unit tests,tscand the plugin build all pass.