Skip to content

A sync that did not reach a device is no longer called in sync - #154

Merged
Omar-VF merged 1 commit into
dev-publicfrom
fix/cli-sync-summary
Nov 11, 2026
Merged

Omar-VF merged 1 commit into
dev-publicfrom
fix/cli-sync-summary

Conversation

@Omar-VF

@Omar-VF Omar-VF commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

The CLI and the Deck plugin both summarise a sync by reading what happened with each device. Any status they didn't know counted as in sync:

From the other device Meaning Said before
peer_playing the game is being played there in sync
peer_paused syncing is paused there in sync
unwritable the save folder here can't be written to in sync
error the sync with that device failed in sync

So opensave sync could say "already in sync" about a save that hadn't gone over. On the Deck it was worse: at a launch, a game being played on the PC came back as in sync, and the Deck started it quietly on the save it had.

Now

  • Each of those is said for what it is, e.g. "it is being played on PC; its save comes over when that session ends".
  • A failed sync with a device is a failure: the CLI exits 1 and points to opensave activity, and the Deck reports an error.
  • A status this version doesn't know (from a newer daemon) is shown, not read as in sync.
  • opensave sync <game> no longer says "Synced … with the devices that could take it" when no device took it.
  • The Deck shows the reason in the panel and at a launch.

docs/CLI.md hadn't changed since September. It now covers pause, resume, transfers, activity, sessions, rename, offers, peers trust, emptied, relocate, storage and verify, and lists which of them need a daemon.

Testing

  • New cases in TestSyncOutcomes (CLI) and in the plugin's test_main.py, covering each status, a mix of devices, and an unknown status.
  • go test ./internal/cliapp ./internal/api (incl. TestDeckyPluginContract), the CLI e2e tests, the plugin's unit tests, tsc and the plugin build all pass.
  • Not tried on a Deck.

The CLI and the Deck plugin read a sync's answer per device, and any
status they did not know counted as in sync: another device playing the
game, with syncing paused, a save folder here that could not be written,
or a sync with a device that failed. So "already in sync" was said of a
save that had not gone over, and at a launch the Deck started the game
quietly on the save it had while the game was being played on the PC.

Each of those is now said for what it is. A failed sync with a device
is a failure; a status not known here is shown rather than read as in
sync. The Deck says it at a launch too.

docs/CLI.md also covers the commands added since it was last written:
pause, resume, transfers, activity, sessions, rename, offers, peers
trust, emptied, relocate, storage and verify.
@vercel

vercel Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
open-save Ready Ready Preview Nov 8, 2026 8:05pm UTC

@Omar-VF
Omar-VF merged commit 79eef9d into dev-public Nov 11, 2026
22 checks passed
@Omar-VF
Omar-VF deleted the fix/cli-sync-summary branch November 11, 2026 09:06

This branch was successfully deployed

1 active deployment
Preview — 7d844849 Deployed Nov 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant