Repository navigation
Find Cemu on Windows, and stamp the Deck plugin with the release tag - #151
Merged
Merged
Conversation
Cemu keeps its data in %APPDATA%\Cemu by default. The preset looked in Documents\Cemu, a folder Cemu never picks, so a default Windows install was not found. Cemu also has a Linux build and paths, so it is no longer listed as Windows-only in the preset test, and its Linux path is checked against a real folder. The Deck plugin zip carried whatever version its files said, so v2.4.1 shipped a plugin saying 2.4.0, and plugin managers offered the same update again and again. A release now writes the tag's version into the zip's plugin.json and package.json. A manual run has no tag and keeps the files' version.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes for 2.5.0, for #148 and #149.
Cemu (#148). On Windows the preset looked in
Documents\Cemu\mlc01\usr\save. Cemu's default is%APPDATA%\Cemu\mlc01(CemuApp::DeterminePaths,ActiveSettings::GetDefaultMLCPath), so a default install was not found. The Linux and Flatpak paths were already right. The preset test no longer lists Cemu as Windows-only, and now checks its Linux path against a real folder.Portable installs, older installs that keep their data beside the exe, and a custom
mlc_pathare still not found by the scan. Those folders can be added by hand.Plugin version (#149).
release.ymlcopiedplugin.jsonandpackage.jsoninto the zip as they were, so v2.4.1 shipped a plugin saying 2.4.0. A tagged release now writes the tag's version into both files in the zip, and fails if either doesn't match afterwards. A manual run has no tag and keeps the files' version.Testing.
go test ./internal/presetspasses. Not tried with a real Cemu install. The stamp step only runs on a tag, so its first real run is the beta.