Repository navigation
Folder trust follow-ups: migration 0044, an offer said once - #150
Merged
Merged
Conversation
The table is migration 0044 now, with IF NOT EXISTS, so a database that made it as 0038 keeps it and what it holds. A test opens such a database.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sivadaboi's follow-ups from #132 to the folder-trust work merged in #135, with their authorship kept.
Brought over:
0044, withIF NOT EXISTS. It sorted oddly as0038, before migrationsdev-publicalready has. A database that already made the table under0038(devanddev-publicbuilds) opens and keeps it. AddedTestFolderTrustTableFromAnEarlierBuildOpensfor that.Left out of #132, on purpose:
ab18a56and312260b(catalogue check timing): these fixloadManifestIndexWithin, a helper in Games from your other devices set themselves up again; trust your own devices to choose folders #132's version of the index code.dev-publichas the in-memory index cache instead (Merge dev: games from your devices set themselves up again #135), whosemanifestIndex(wait)already reads the index after waiting.e184eacand9cc6e70(changelog and version): handled at release.Checks: store, p2p, API and daemon tests pass locally.