Skip to content

A drive that is not ready does not hold a save folder - #147

Merged
Omar-VF merged 1 commit into
dev-publicfrom
fix/relocate-unready-drive
Nov 5, 2026
Merged

Omar-VF merged 1 commit into
dev-publicfrom
fix/relocate-unready-drive

Conversation

@Omar-VF

@Omar-VF Omar-VF commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

When a save folder is missing, OpenSave looks for the same path on the other drive letters and offers exactly one match. On a PC with an empty card reader or a similar drive, the offer never appeared.

Why: a candidate counted when it wasn't reported missing (SaveFolderMissing), but only a plain "not there" reads as missing. A drive with no disk in it answers "the device is not ready", so it counted as holding the folder. That made a second match, and OpenSave won't guess between two. As the only match, it would have been offered as a folder that isn't there.

The change: relocateCandidates counts a candidate only when its folder can be seen to exist (saveFolderThere). SaveFolderMissing is unchanged, since its other callers rightly don't call an unreachable drive "missing".

Tests: TestRelocateToOtherDrive_ADriveNotReadyIsNoMatch fails under the old rule. The three existing TestRelocateToOtherDrive_* tests failed on a PC with an empty card reader and pass now. CI's Windows machines have no such drive, which is why it never showed there.

A missing save folder is looked for at the same path on the other drive
letters, and exactly one match is offered. A candidate counted when it
was not reported missing, but only a plain "not there" reads as missing:
a drive with no disk in it, such as an empty card reader, answers "the
device is not ready". It counted as holding the folder, made a second
match, and nothing was ever offered. On its own it would have been
offered as the folder. A candidate now counts only when its folder can
be seen to exist.
@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
open-save Ready Ready Preview Nov 5, 2026 10:23am UTC

@Omar-VF
Omar-VF merged commit 5c43384 into dev-public Nov 5, 2026
22 checks passed
@Omar-VF
Omar-VF deleted the fix/relocate-unready-drive branch November 5, 2026 10:37

This branch was successfully deployed

1 active deployment
Preview — 24b29c8e Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant