Repository navigation
A drive that is not ready does not hold a save folder - #147
Merged
Merged
Conversation
A missing save folder is looked for at the same path on the other drive letters, and exactly one match is offered. A candidate counted when it was not reported missing, but only a plain "not there" reads as missing: a drive with no disk in it, such as an empty card reader, answers "the device is not ready". It counted as holding the folder, made a second match, and nothing was ever offered. On its own it would have been offered as the folder. A candidate now counts only when its folder can be seen to exist.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a save folder is missing, OpenSave looks for the same path on the other drive letters and offers exactly one match. On a PC with an empty card reader or a similar drive, the offer never appeared.
Why: a candidate counted when it wasn't reported missing (
SaveFolderMissing), but only a plain "not there" reads as missing. A drive with no disk in it answers "the device is not ready", so it counted as holding the folder. That made a second match, and OpenSave won't guess between two. As the only match, it would have been offered as a folder that isn't there.The change:
relocateCandidatescounts a candidate only when its folder can be seen to exist (saveFolderThere).SaveFolderMissingis unchanged, since its other callers rightly don't call an unreachable drive "missing".Tests:
TestRelocateToOtherDrive_ADriveNotReadyIsNoMatchfails under the old rule. The three existingTestRelocateToOtherDrive_*tests failed on a PC with an empty card reader and pass now. CI's Windows machines have no such drive, which is why it never showed there.