fix: Simplify session store and delete logic#3
Open
Unbreathable wants to merge 2 commits intomainfrom
Open
Conversation
- Also make sure sessions are properly copied
There was a problem hiding this comment.
Pull request overview
This PR refactors the session management system to remove the global mutex (SessionCache struct with its global mutex) and simplify the session store and delete logic. The changes aim to improve concurrency by relying on sync.Map's built-in synchronization and per-SessionsList mutexes rather than a single global lock.
Changes:
- Removed the
SessionCachewrapper struct with its global mutex, replacing it with direct use ofsync.Map - Refactored
createSessionto useLoadOrStorepattern instead of multiple Load operations with global locking - Updated
GetSessionsto create defensive copies of session slices to prevent external modification - Simplified
SendEventToUserandGetConnectionsto reuseGetSessionsmethod
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| neogate.go | Removes SessionCache struct and global mutex, replaces with direct sync.Map usage |
| sessions.go | Refactors session creation/deletion logic and adds defensive copying in GetSessions |
| send.go | Simplifies SendEventToUser by reusing GetSessions method, removes unnecessary error handling |
| connections.go | Simplifies GetConnections by delegating to GetSessions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR does the following things: