Skip to content

added confirmation textbox to delete extensions and refresh button for list views#122

Merged
nadirhamid merged 4 commits into
masterfrom
registration-bug-fix
Apr 27, 2026
Merged

added confirmation textbox to delete extensions and refresh button for list views#122
nadirhamid merged 4 commits into
masterfrom
registration-bug-fix

Conversation

@royking01
Copy link
Copy Markdown
Collaborator

No description provided.

@royking01 royking01 requested a review from nadirhamid April 17, 2026 07:17
@royking01 royking01 self-assigned this Apr 17, 2026
Copy link
Copy Markdown
Contributor

@nadirhamid nadirhamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refer to the comments.

<tbody md-body>
<tr md-row md-select="number" md-select-id="name" md-auto-select ng-repeat="extension in extensions">
<td md-cell>
<td md-cell style="padding-left: 24px !important;">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why you made this change ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list's checkbox positions are inconsistent with the header checkbox position. The UI looks very unbalanced, so this is a small UI fix for that.

Comment thread app/index.html Outdated
<link rel="preload" ng-href="{{$shared.getEditorResource('app.min.css')}}" as="style">
<link rel="preload" ng-href="{{$shared.getEditorResource('main.min.js')}}" as="script">

<script src="https://challenges.cloudflare.com/turnstile/v0/api.js" async defer></script>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anyway we can check if the login verification attribute in the settings API is set to cloudflare before adding this lib to the DOM ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay will confirm and revert back.

@nadirhamid nadirhamid merged commit 348c71c into master Apr 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants