Skip to content

fix(sws): align Kurlyk with maintained Simple-WebSocket-Server - #47

Merged
LimiNode merged 3 commits into
mainfrom
test/maintained-sws-baseline
Oct 7, 2026
Merged

LimiNode merged 3 commits into
mainfrom
test/maintained-sws-baseline

Conversation

@LimiNode

@LimiNode LimiNode commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • pin the bundled and FetchContent Simple-WebSocket-Server dependency to maintained commit de7cb7c39edd6b4178adcc3f5f17d219720b3cdb;
  • support the installed SimpleWebSocketServer::simple-websocket-server CMake package;
  • reject installed SWS targets whose Asio backend conflicts with Kurlyk's selection;
  • add installed-package consumers for standalone/Boost and a controlled mismatch failure;
  • add a real remote FetchContent C++11 smoke matrix with the SWS submodule removed.

The previous MinGW ScopeRunner TLS-cleanup regression was fixed in the maintained SWS baseline and no longer reproduces locally.

Validation

  • local SWS swss_io_test: PASS;
  • local Kurlyk ws_local_test: PASS;
  • exact-head GitHub CI run #37641018110: PASS;
  • MinGW ws_local_test: PASS;
  • remote FetchContent standalone/Boost: PASS;
  • installed SWS standalone/Boost: PASS;
  • installed backend mismatch rejection: PASS.

Scope constraints

Constraint: Keep vcpkg PRs and releases unchanged

Rejected: SWS v2.0.2 compatibility bridge | maintained baseline uses current API

Confidence: high

Scope-risk: moderate

Not-tested: Native runtime loopback and Boost CMake package consumer
Constraint: Keep vcpkg ports, PRs, tags, and releases unchanged

Rejected: silently accepting installed SWS backend mismatches | conflicting macros can break consumers

Confidence: high

Scope-risk: moderate

Not-tested: Passing local MinGW websocket runtime; ws_local_test crashes in maintained SWS TLS cleanup
Constraint: Keep vcpkg ports, PRs, tags, and releases unchanged

Confidence: high

Scope-risk: narrow

Not-tested: Full GitHub CI matrix after the upstream SWS fix
@LimiNode
LimiNode marked this pull request as ready for review October 7, 2026 18:02
@LimiNode
LimiNode merged commit bf37cbb into main Oct 7, 2026
10 checks passed
@LimiNode
LimiNode deleted the test/maintained-sws-baseline branch October 7, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant