Repository navigation
fix(widgets): compact time offset popup layout - #242
Merged
Merged
Conversation
Allow callers to control the outer time offset popup padding while preserving ambient style values for nested controls.
Describe popup spacing and padding inheritance for TimeOffsetPicker callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
popup_item_spacingandpopup_window_paddingfor popup-local layout control;ImGuiFramedWindowchild-window style scopes immediately afterBeginChild();side_panel_width <= 0;Verification
cmake --build external/ImGuiX/build-mingw --parallel 36ctest --test-dir external/ImGuiX/build-mingw --output-on-failure(19/19)mgc-guibuild against the updated widgetgit diff --checkThis PR is intentionally separate from the already merged content-surface work.