Conversation
test cov: offcurve, zero-amounts test cov: dupe hash failure, v1 reject at ixn boundary more test cov load, add freeze thaw, extend test cov add tests lint frozen handling more tests mark internals rm _tryfetchctokencoldbyaddress cleanups fmt
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (83)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[Warning] "c-token" in JSDoc of brand-new freeze-thaw.tsFile: New file uses "c-token" 8 times in JSDoc despite being added on the rename branch. Should say "light-token". |
[Warning] CHANGELOG incomplete -- only documents decompressInterface removalFile: Does not document the many other breaking changes:
Also uses "c-token" terminology in the new entry (line 6). |
[Warning] Test filename uses old naming: freeze-thaw-ctoken.test.tsFile: Should be |
[Warning] Misleading test name: "partial freeze" tests full freezeFile: Test named |
[Warning] Unused addressTreeInfo in 10 test casesFile:
|
[Warning] Unused imports in mint-to-light-token.test.tsFile:
|
[Warning] Magic byte offsets in tests instead of structured deserializationFiles:
Using |
[Warning] Unified index missing freeze/thaw exportsFile:
|
[Warning] Incomplete TLV extension parserFile:
const SIZES: Record<number, number | undefined> = {
29: 8,
30: 1,
31: 17,
};
const size = SIZES[disc];
if (size === undefined) return null; // silently fails for unknown extensions |
[Nit] Redundant assertNotFrozen double-callFile:
|
[Nit] Redundant spread propertyFile:
|
[Nit] Duplicate imports from same moduleFile: Two separate imports from import { getAssociatedLightTokenAddress, findMintAddress } from '../../src/v3/derivation'; |
[Nit] Unexplained 1-second sleep in testFile: Bare |
[Nit] Hardcoded program ID strings in testsFile: Uses literal |
No description provided.