Repository navigation
Label the decision rationale consistently and give tables the page column - #25
Merged
Merged
Conversation
…lumn Embedded decision blocks called their rationale view "Narrative" while the shared record dialog labels the same field "Rationale"; the block's view id and button now say rationale too. Table outputs were capped at the 40rem editorial measure like figures, so a wide registry scrolled inside a 640px box on a 1900px article. They now take the page column of the article grid, as a MyST col-page figure does, while their caption and provenance drawer keep the measure. Refs #22 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Lightcone previews: Paper · Playground — inventory, viewers, dialogs and glyphs 45ef7f6 · @astra-spec/ui 0.0.6 from 6248ae0 · Lightcone brand 0.0.3 · astra-theme 45ef7f6 · content 3735fcc · MySTRA https://github.com/LightconeResearch/MySTRA/releases/download/v0.0.8/mystra.mjs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the still-open items from #22.
"Narrative" vs "Rationale"
Decision blocks embedded on sub-analysis pages (
:::{astra} reconstruction.decisions.algorithm…) rendered the theme's own panel with a Narrative | Options toggle, while the shared record dialog opened from an inline reference labels the samerationalefield Rationale. The block's view id is nowrationale, so the button reads Rationale and the two surfaces agree. The component test follows.Tables were width-restricted
.astra-outputcaps every output at the 40rem editorial measure, so both tables on the DESI paper scrolled inside a 640px box while the article grid was 1905px wide. Table outputs now span thepagecolumn of the article grid, the same treatment MyST gives acol-pagefigure; figures keep the measure. Measured locally at a 1920px viewport:tbl-bao-alpha-valuestbl-bao-distancesThe caption and the provenance drawer keep the measure so the caption stays at reading width. On small screens the
pageandbodylines coincide, so nothing changes there.One thing to be aware of: like any MyST wide block, a page-wide table passes under the sticky "In this article" outline while it sits at the top of the viewport on large screens. That is the stock behaviour for
col-pagecontent and not something this PR changes.Verification
npm test: 16 files, 143 tests pass./reconstructionrenders Rationale | Options, and both tables take the page column with 640px captions.🤖 Generated with Claude Code