fix(backend): update core files for correct SMILE methodology#17
Open
jv-singh wants to merge 2 commits into
Open
fix(backend): update core files for correct SMILE methodology#17jv-singh wants to merge 2 commits into
jv-singh wants to merge 2 commits into
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The previous codebase hardcoded a hallucinated 5-phase acronym (SENSE → MODEL → INTERVENE → LEARN →
EVOLVE) that does not exist in the LPI data source. The real SMILE is Sustainable Methodology for Impact
Lifecycle Enablement — 6 sequential phases sourced verbatim from data/smile-framework.json.
This PR replaces the 5-phase enum with the correct 6-phase enum, recomputes the scoring formula, rewrites
the SMILE and scoring tests for the new phases, and fixes three documentation files that still contained
literal "sense" strings — anyone copying the QA matrix or running the proxy-data script would have hit 422
validation errors otherwise.
Phases (correct, in order):
The transition rule (forward one step allowed, backward any, skip forbidden, same-phase forbidden) is
unchanged — only the phases it operates on were wrong.
Score range: [0.80, 6.70] → [0.80, 7.00] (PERPETUAL_WISDOM = 6, the new max weight).
Closes the test failures in tests/test_smile.py and tests/test_scoring.py caused by phase-name mismatches.
Type
get_phase_key_question())
Checklist
tests/test_smoke.py, tests/test_goal_crud.py, tests/conftest.py)
staging
Tests passing
(6 tests)
TestScoreGoalWithUrgency (4 tests), TestScoreGoalProperties (5 tests), TestSortGoalsByScore (9 tests),
TestScoreExplanation (5 tests) — 48 tests total, up from 46
all phase literals now correct
Daily report reference
reports/2026-06-06.md (to be created — covers the SMILE 6-phase correction and the doc-only follow-up)
Files changed
LPI_SMILE_Written_Report.pdf