Skip to content

fix(webhook): fill source metadata and persist ReviewOutput for webhook reviews (#137) - #138

Merged
Liewzheng merged 7 commits into
mainfrom
feat/webhook-review-output
Sep 2, 2026
Merged

fix(webhook): fill source metadata and persist ReviewOutput for webhook reviews (#137)#138
Liewzheng merged 7 commits into
mainfrom
feat/webhook-review-output

Conversation

@Liewzheng

Copy link
Copy Markdown
Owner

Fixes #137.

What changed

  • Webhook-triggered reviews (GitLab/GitHub) now build a rich "SourceMeta" from the incoming payload and back-fill authoritative fields from MRInfo before the expert run, so the History list no longer shows "Untitled" / "unknown" for MR title, project, or author.
  • The task store now persists the full "ReviewOutput" (including per-expert reports) when a webhook review completes, so the History detail panel renders the expert results instead of an empty list.
  • GitHub webhook handler is wired into the task store lifecycle (previously only GitLab recorded tasks).
  • Serialization failure during outcome recording now marks the task Failed instead of Completed with a null result.
  • GitHub PR payload now extracts target_branch from pull_request.base.ref.

Verification

  • cargo fmt --check ✅
  • cargo clippy --all-targets --all-features ✅
  • cargo test ✅ (1571 passed)
  • cd frontend && npm run build ✅

…ok reviews (#137)

- Move source_meta_from_mr_info into task_queue and back-fill authoritative fields before the expert run.

- Record the full ReviewOutput JSON on webhook completion so the History detail panel renders expert results.

- Parse richer payload metadata (title, project, author, branch, target_branch) for GitLab and GitHub webhooks.

- Fail the task if ReviewOutput serialization ever errors instead of storing null.

- Extract target_branch from GitHub PR payload.

- Fixes #137
@Liewzheng
Liewzheng merged commit fdec8da into main Sep 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhook-triggered reviews show Untitled / unknown project / author in History/Queue

1 participant