Skip to content

ci: fix the pipeline against Nextcloud master and stable35 - #128

Merged
vitormattos merged 11 commits into
mainfrom
fix/ci-php-83
Sep 9, 2026
Merged

vitormattos merged 11 commits into
mainfrom
fix/ci-php-83

Conversation

@YvesCesar

@YvesCesar YvesCesar commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

Summary

The CI pipeline was broken against current Nextcloud. This PR fixes every failing job and adapts the app to the personal settings page rewritten in Nextcloud 35.

What was failing and why

Job Cause
Behat / Playwright Nextcloud master requires PHP 8.3, the workflows used 8.2
PHPUnit (master, stable35) Schema::changeColumn() was removed, and ISchemaWrapper now types its return with ITable/IColumn
Static analysis Psalm reported the Doctrine docblock suppression as unused on some branches
Playwright The personal settings section was renamed and the page markup no longer exposes the DOM hooks the app embeds into

Changes

CI

  • Bump PHP from 8.2 to 8.3 in behat-sqlite.yml and playwright.yml.
  • Set findUnusedIssueHandlerSuppression="false" in psalm.xml, so a suppression that is required on one supported branch is not reported as unused on another.

Migration

  • Version1001Date20260404010000 sets the column attributes directly instead of calling changeColumn(), which no longer exists. The behaviour is unchanged and it stays compatible with Nextcloud 32 through 35.

Nextcloud 35 personal settings

  • PersonalInfo::getSection() returns profile-contact when the renamed core section class is present, and personal-info otherwise.
  • The shell placement logic moved from src/settings-personal.ts to src/utils/embeddedShellPlacement.ts and now handles both layouts: the legacy
    #personal-settings grid, and the new .settings-column page, where the shell is appended to the settings section and rendered as a full-width column.
  • A MutationObserver re-places the shell when the core renders its section late.

Behaviour note

On Nextcloud 35 the fields render as a full-width block inside the profile
section, not spanning a two-column grid — the new page has no grid to span.

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
@YvesCesar
YvesCesar marked this pull request as draft September 7, 2026 17:04
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…lumn

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…orted branch

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…rapper

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
… PersonalTest

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…med in Nextcloud 35

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…te section

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…swap

Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
@YvesCesar YvesCesar changed the title ci: bump PHP to 8.3 to match Nextcloud master requirement ci: fix the pipeline against Nextcloud master and stable35 Sep 8, 2026
@YvesCesar
YvesCesar marked this pull request as ready for review September 8, 2026 21:19
@vitormattos
vitormattos merged commit 77696e8 into main Sep 9, 2026
23 checks passed
@vitormattos
vitormattos deleted the fix/ci-php-83 branch September 9, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants