Repository navigation
Format municipal service code in ADN request paths - #90
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADN municipal-parameters API documentation and official examples use the 9-digit service code formatted in the path as
XX.XX.XX.XXX(for example07.02.01.001).The client previously validated the 9 digits but stripped punctuation and sent
010101000, which the real ADN endpoint rejects with:Chamada mal formada. O código do serviço deve ser composto por nove dígitos.This PR keeps digit-only normalization/validation at the API boundary, but serializes the path segment in the official dotted format.
Regression tests now assert:
010101000->01.01.01.000