Repository navigation
docs(danfse): correct legacy IBS/CBS visibility contract (#118) - #140
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contraprova reproduzível
O contrato estável de
docs/danfse-v2-rendering.mdafirmava que o bloco IBS/CBS só era renderizado quando presente no XML autorizado. Porém:src/Danfse/HTMLTemplate.phpmantém a seçãoTRIBUTAÇÃO IBS / CBStambém nos casos legados sem esse grupo;tests/Unit/Danfse/DanfseGoldenReferenceTest.php::testAuthorizedXmlWithoutIbsCbsStillRendersRequiredV2Sectionetests/Unit/Danfse/DanfseTemplateTest.php::testRenderShowsRequiredIbsCbsSectionEvenWithoutAuthorizedIbsCbsGroupexigem explicitamente essa apresentação;Alteração mínima
Corrige apenas uma afirmação da documentação de contrato estável, alinhando-a aos testes já existentes. Não altera XML, modelos, HTML, PHP, Dompdf, fontes, artefatos fiscais, Composer, consumidor Akaunting ou históricos.
Evidência, revisão e limites
c418a19ed9e0517350682321dc75ddd5d511d8b1, assinado GPG e com DCO confirmado pelo Git Signing MCP; base conferida22b71d6b1a0949197412b625759d8015d32c1b54.#118identificou separadamente divergência de posicionamento vertical do QR Code em PDFs sintéticos: Y ≈ 1,36 cm versus 1,67 cm no item 2.4.3 da NT008. Essa investigação/correção de layout está fora do escopo deste PR documental.#118; exige aceite próprio após conclusão dos bloqueios e autorização específica de publicação.Refs #118.