Repository navigation
fix(danfse): bundle and embed Liberation Sans by default (#137) - #138
Merged
Merged
Conversation
…137) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…rifier (#137) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…#137) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…chive (#137) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…isory exception (#137) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…nt provenance (#137) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
marked this pull request as ready for review
October 12, 2026 20:10
…#137) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objetivo
Executa nfse-php #137: empacotar Liberation Sans 2.1.5 Regular/Bold sob OFL-1.1, selecionar as fontes incorporadas por padrão (sem downloads em runtime), preservar fontes personalizadas, cache isolado e XML autorizado, e comprovar página única A4 com PDFs sintéticos.
Política de dependência — revisão em 12/10/2026
dompdf/dompdf: ^3.1.6. O suporte à série 2.x foi removido conforme decisão do projeto; não há fallback nem instalação de Dompdf 2..github/workflows/danfse-visual.ymlexecuta somente Dompdf 3, instalando dependências normalmente, semCOMPOSER_POLICY_ADVISORIES_BLOCK, sem matriz de majors e sem lógica de assertiva embutida em Bash.pdffonts,pdfinfo,pdftotextvia verificador em PHP e compara os PDFs de cenários sintéticos.akaunting-nfseutilizanfse-phppor commit pinado em3rdparty/composer.json; a alteração desse pin e o teste de runtime escopado devem ocorrer na etapa de integração do consumidor, não implicitamente por este PR.Implementação e testes
tools/src/DanfsePdfEvidence.php, com testes PHPUnit e CLIverify-danfse-visual-fixtures.php.composer archiveverificado porverify-danfse-composer-package.php: fonts, NOTICE, OFL, checksum e classe. Comandos locaiscomposer run danfse:packageecomposer run danfse:visual.Limites normativos e governança
.github/CODEOWNERSatualmente lista somente o autor do PR (@vitormattos), bloqueando aprovação independente até solução legítima de governança.Conferência
composer test,composer cs:check,composer psalm,composer run danfse:visual.PR #138 permanece aberto para a revisão requerida; issue #137 permanece aberta até satisfação de todos os critérios.
Checks no HEAD atual — f344818
skipped, zero falhas/cancelamentos/pendências. Verificado após a migração obrigatória para Dompdf 3.1.6.dompdf/dompdf v3.1.6, validação do arquivo Composer aprovada, 145 testes/532 assertions de DANFSe aprovados, PDFs A4 gerados e inspecionados com fontes incorporadas.