Repository navigation
fix: validate published NT009 preview constraints after #101 (#95) - #102
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #95 — post-PR #101 NT009 normative preview guards
Follow-up to merged PR #101, based on main at
2c5c84630eab28e0653c40c793f1bb2ba4fab553.Source-backed changes
vAjusteAplic > vTotDoc(row 301) with arbitrary-precision decimal-as-string comparison, avoiding floats and integer overflow.xTipoChaveDFeto type 9 (rows 305–306).xTpAjusteBCLocImoveisto 99 (rows 401–402).docs/NT009-CONTRACT-IMPLEMENTATION.md.Compatibility and safety
DpsData, legacyXmlBuilder::buildDps(),DpsSchemaValidator,NfseClient::emit(), or the downstream Akaunting dependency.Validation
Explicitly unresolved — do not close issue #95
The government portal does not yet establish a deployed environment-specific NT009-compatible official XSD and activation date. The unresolved
gIBSCBSAjustehierarchy conflict (NT009 PDF versus Annex VI), independent taxpayer-classification/repercussion rules, complete version-specific emitting API and XSD/SEFIN acceptance remain blockers. The preview is not a certified production emitter. Do not promote it toNfseClient::emit()or updateakaunting-nfse's Composer pin on this basis.This PR fixes the demonstrable post-#101 gaps that can be resolved without inventing fiscal semantics; it does not claim 100% completion of #95.