Repository navigation
fix(nfse): isolate municipal item diagnostics by company profile (#421) - #493
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…rtions Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
O composer das telas nativas de itens (
Providers/Main.php) obtinha município e ambiente desetting('nfse.municipio_ibge')esetting('nfse.sandbox_mode'), legados e sujeitos ao contexto ativo, inclusive quando o perfil fiscal da empresa não existe. Também consultava perfis de itens sem filtro empresarial quandocompany_id()era zero.Mudança
ItemMunicipalCompanyContextlê somente o perfil fiscal ativo docompany_idproprietário; sem perfil ou empresa válida, retorna município desconhecido, impedindo vinculação de evidência municipal de outro tenant.NfseCompanyFiscalSettings, nuncanfse.*legado.Testes
Feature verifica conflito com settings legados e contextos de duas empresas com o mesmo CNPJ mas municípios e ambientes diferentes. CI de PHP, Feature, Psalm, estilo e demais checks aplicáveis devem passar.
Governança
Commits incrementais Conventional Commits, DCO e assinatura criptográfica via Git Signing MCP. PR draft até CI final e revisão. Sem alteração de migrations, dados históricos, CODEOWNERS ou bypass.