Repository navigation
fix(nfse): restore owning company context for queued post-emission work (#421) - #492
Merged
Merged
Conversation
…nership Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ore context Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema confirmado
StoreIssuedNfseArtifactseSendIssuedNfseEmailrecebiam apenas IDs de fatura/recibo, sem ativar a empresa. Um worker sem empresa corrente, ou com outra empresa corrente, poderia falhar ou lernfse.webdav_*e preferências de envio do tenant errado. O teste anterior selecionava manualmente a empresa antes da chamada, por isso não verificava a execução real em fila.Correção
NfsePostEmissionCompanyContextconsulta o dono na associação persistida entrenfse_receiptsedocuments; rejeita identidade ausente/inconsistente antes de qualquer operação externa.Company::makeCurrent()egetCurrent(); restaura o contexto anterior (ou remove a seleção temporária) emfinally, inclusive após exceção.Provas
Feature sintético verifica dois contextos com URLs WebDAV diferentes, troca e restauração após sucesso/falha, e rejeição por recibo divergente sem disparar callback. PHPUnit, Akaunting Feature, Psalm, PHP-CS-Fixer, Playwright aplicáveis devem passar.
Governança
Commits incrementais Conventional Commits, DCO e assinados criptograficamente via Git Signing MCP. PR draft até CI/revisão; sem bypass de ruleset, squash ou transmissão fiscal real. Complementa os PRs #482/#484 já integrados.