Skip to content

64 Driver Parser - #110

Open
epii-1 wants to merge 2 commits into
masterfrom
64-driver-parser
Open

64 Driver Parser#110
epii-1 wants to merge 2 commits into
masterfrom
64-driver-parser

Conversation

@epii-1

@epii-1 epii-1 commented Aug 31, 2020

Copy link
Copy Markdown
Collaborator

driver.js generation should now (be able to) reflect configuration changed.

Both delete-functions (and maybe update-functions too?) should likely be marked in similar fashion as the creationDate and lastUpdateDate. To completely turn them of when the api+resolver for them are not generated.

Anyone have any comments on this implementation? @hartig @keski @rcapshaw
Should currently not impact anything for spirit.

Closes #64

@keski

keski commented Sep 10, 2020

Copy link
Copy Markdown
Collaborator

@epii-1, I believe you forgot to include the driver parser file. That being said, I think this might be a bit overkill (see #64). I'd suggest instead simply adding flags to the server.js call, and then call functions that conditionally add/update the corresponding date fields if enabled.

@epii-1 @hartig

@epii-1

epii-1 commented Sep 10, 2020

Copy link
Copy Markdown
Collaborator Author

@keski graphql-server/drivers/driver_parser.py is included (with the second commit).
But indeed, simply adding flags to the update and create calls should work just fine (with a very tiny overhead increase that can safely be ignored).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some configurations are not reflected in the drivers.js

2 participants