Skip to content

fix: anchor keyboard chat after dismiss#449

Open
ludwig-pro wants to merge 1 commit into
LegendApp:mainfrom
ludwig-pro:fix/android-ai-chat-anchor
Open

fix: anchor keyboard chat after dismiss#449
ludwig-pro wants to merge 1 commit into
LegendApp:mainfrom
ludwig-pro:fix/android-ai-chat-anchor

Conversation

@ludwig-pro

@ludwig-pro ludwig-pro commented May 22, 2026

Copy link
Copy Markdown

Summary

  • wait for keyboard dismissal before calling scrollToEnd in keyboard chat flows
  • keep freeze cleanup in a finally block
  • add integration coverage for the dismiss -> frame -> scroll ordering

Validation

  • bun test __tests__/integrations/keyboard-chat.test.tsx
  • bun run tsc:src
  • bun run lint
  • Verified AI Chat send behavior with agent-device on Android and iOS

Before

BEFORE

After

AFTER

@jmeistrich

Copy link
Copy Markdown
Member

Hmm, it seems to fix Android while making iOS worse? In an earlier version I had it waiting a frame only on Android, but I thought it was fixed when using react-native-keyboard-controller version 1.21.7. Are you on that and LegendList beta.56?

At least it looked good on my Android device. I'll try it again and see if it looks bad like that on my slower Android phone.

@ludwig-pro

Copy link
Copy Markdown
Author

i'm using the app example ( main branch + "react-native-keyboard-controller": "^1.21.7" ), I will retry with a physical android device

@ludwig-pro ludwig-pro force-pushed the fix/android-ai-chat-anchor branch from c9ae7a2 to 55b0434 Compare May 29, 2026 09:39
@ludwig-pro ludwig-pro force-pushed the fix/android-ai-chat-anchor branch from 55b0434 to f44e82b Compare May 29, 2026 12:48
@ludwig-pro

Copy link
Copy Markdown
Author
to-convert-gif

I will also record the behavior on physical device

@ludwig-pro

ludwig-pro commented Jun 1, 2026

Copy link
Copy Markdown
Author

Behavior on physical device :

WDYT @jmeistrich ?

iOS Android
legend-list-1-under-10mb screen-20260601-111017-1780304989594-under-10mb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants