fix: anchor keyboard chat after dismiss#449
Open
ludwig-pro wants to merge 1 commit into
Open
Conversation
Member
|
Hmm, it seems to fix Android while making iOS worse? In an earlier version I had it waiting a frame only on Android, but I thought it was fixed when using At least it looked good on my Android device. I'll try it again and see if it looks bad like that on my slower Android phone. |
Author
|
i'm using the app example ( main branch + "react-native-keyboard-controller": "^1.21.7" ), I will retry with a physical android device |
c9ae7a2 to
55b0434
Compare
55b0434 to
f44e82b
Compare
Author
Author
|
Behavior on physical device : WDYT @jmeistrich ?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
scrollToEndin keyboard chat flowsfreezecleanup in afinallyblockValidation
bun test __tests__/integrations/keyboard-chat.test.tsxbun run tsc:srcbun run lintagent-deviceon Android and iOSBefore
After