Repository navigation
deps(#607): bump the all group across 1 directory with 3 updates - #602
Conversation
|
Independent Codex source review at I read both changed manifests and compared every lockfile package structurally. The package set is unchanged. Rollup and all 25 platform packages advance together to 4.63.2; their platform and optional flags are retained. Vite advances to 8.3.0 with its PostCSS/nanoid changes, and the lock preserves the existing Node22.15.1/npm11.5.2 contract. Vite's Node peer range includes that configured Node release. The additional arm64-musl entry in the lock's root dependency map retains the explicit optional entry and optional package flag; it does not introduce a new package. Scope stays in marketing/package.json and marketing/package-lock.json. The application's source and root/workspace lockfile are unchanged. The title and body now trace to #607. This is a source/manifest review, not a claim of independent builds on every listed CPU/OS. Final merge remains conditional on all latest CI checks, an updated main, renewed review of any source delta, and the recorded #574 slot/order. |
|
First-reader review at 71777bc Verdict: approve at Reviewer: Claude (Opus 5), first reader. I am neither the author (Dependabot) nor whoever retitled the PR. Depth, proportionate to a patch and minor bump:
BlockingNone. Before merge
Non-blocking
Lockfile
Release notes against
|
| Command | Result |
|---|---|
npm --prefix marketing ci --ignore-scripts |
exit 0: "added 418 packages, and audited 425 packages in 2s". Installed vite 8.3.0, rollup 4.63.2, postcss 8.5.28, nanoid 3.3.19, rolldown 1.2.7. vite --version reports vite/8.3.0 linux-x64 node-v22.15.1 |
npm --prefix marketing run build (tsc -b && vite build) |
exit 0: "✓ 4575 modules transformed", "✓ built in 173ms" |
npm --prefix marketing run lint (eslint .) |
exit 0, no findings |
npm --prefix marketing run test |
no such script (finding 4) |
npm --prefix marketing run type-check |
exit 0 |
npm --prefix marketing run format:check |
exit 1 on README.md, same at main (finding 3) |
npm --prefix marketing audit --omit=dev --audit-level=low, as CI runs it, and a full audit |
"found 0 vulnerabilities" from both |
Baseline at the old main 7eb3ad2c: the same ci and build with vite/8.2.2, exit 0. Comparing the two dist/ directories:
- 13 files on each side, and the CSS is identical.
- Only the JS bundle (282,940 → 282,962 bytes) and its hashed name in
index.htmldiffer. - The JS difference is exactly
.filter(e=>e!==void 0)added to the preload helper, the 22-character change from feat(build): avoid settling seen preload dependencies for performance vitejs/vite#23446. So the head build really ran on 8.3.0.
Dev server at the head: vite --strictPort on a free port with VITE_HOST=127.0.0.1 printed "VITE v8.3.0 ready".
GET /returned 200 with/@vite/clientinjected.GET /src/main.tsxreturned 200.- The same request with
Host: evil.examplereturned 403, soallowedHostsis still enforced.
On main now: ea3d39cb with this PR's two package files, as described under "Before merge".
Lockfile regeneration: npm install --package-lock-only --ignore-scripts with npm 11.5.2, from copies of the head's and main's package.json and lockfile (finding 2).
Hosted CI at 71777bc5
Read at 2026-09-15T13:12:36Z from the check-runs API: 11 check runs at this sha.
| Check | State | Completed (UTC) |
|---|---|---|
| Android Release and native probe | skipped | 2026-09-15T12:42:35Z |
| Build & test (JS workspaces + contracts) | success | 2026-09-15T12:48:44Z |
| Determine native build scope | success | 2026-09-15T12:42:35Z |
| Django checks & tests | success | 2026-09-15T12:55:39Z |
| Django ordinary suite | success | 2026-09-15T13:09:05Z |
| GitGuardian Security Checks | success | 2026-09-15T12:42:56Z |
| Mobile native checks | success | 2026-09-15T12:42:45Z |
| PR type and issue | failure (superseded: the run before the retitle; a later run on this sha passed) | 2026-09-15T12:42:33Z |
| PR type and issue | success | 2026-09-15T12:56:12Z |
| Source gates | success | 2026-09-15T12:43:25Z |
| iOS ad hoc simulator Release and native probe | skipped | 2026-09-15T12:42:35Z |
Metadata
- Title:
deps(#607): bump the all group in /marketing with 3 updates. - First body line:
Refs #607. Dependency updates opened by Dependabot after the organization transfer #607 is the owner's tracking issue, and it names this PR for merge after CI and an independent read. closingIssuesReferences:[].- Commit: the one commit's headline is
chore(deps): bump the all group in /marketing with 3 updates. Neither it nor the commit body contains a closing keyword. - PR metadata runs on the same head sha (
pull_request_target):- run 34970433917 at 12:42 UTC, before the retitle: failed with "Use a title like fix(The wallet verification workflow moves into a service #123)…";
- run 34971825396 at 12:56 UTC, after the retitle: passed.
- Local gate:
python scripts/check-pr-metadata.py --repository Ledova/ledova --pr 602, with gh 2.100.0, printed "PR deps(#607): bump the all group across 1 directory with 3 updates #602 has a typed title and matching reference to issue Dependency updates opened by Dependabot after the organization transfer #607 in Ledova/ledova." and exited 0. - Branch against main: the API compare
main...71777bc5, read at 2026-09-15T13:12:36Z, givesbehind_by3 andahead_by1, with main atea3d39cb(docs(#554): name the Ledova organization in repository links #603). GitHub reportsmergeableasMERGEABLE.
Not checked
- building the production Docker image (
node:22.15.1-alpine), where the musl rollup binaries matter; - any install on arm64 musl;
- browser rendering of the built site.
|
@dependabot rebase |
Bumps the all group with 3 updates in the /marketing directory: [rollup](https://github.com/rollup/rollup), [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) and [@rollup/rollup-linux-arm64-musl](https://github.com/rollup/rollup). Updates `rollup` from 4.63.1 to 4.63.2 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.63.1...v4.63.2) Updates `vite` from 8.2.2 to 8.3.0 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/create-vite@8.3.0/packages/vite) Updates `@rollup/rollup-linux-arm64-musl` from 4.63.1 to 4.63.2 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.63.1...v4.63.2) --- updated-dependencies: - dependency-name: "@rollup/rollup-linux-arm64-musl" dependency-version: 4.63.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: rollup dependency-version: 4.63.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: all - dependency-name: vite dependency-version: 8.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <support@github.com>
71777bc to
a3b5989
Compare
|
Codex independent source review at Source approval carries from71777bc5 (review5680643925). I compared Git tree entries for both changed files: This is source-delta clearance, not a new build/test claim. Current-head hosted checks, Claude's first-reader requirements and immediate pre-merge main/slot verification remain required. The owner's order change in #574 comment5687639200 puts this PR before corrected #609; Codex is holding its merge accordingly. |
|
First-reader confirmation at a3b5989: approval carries My approval of
All 11 current-head check runs have completed; nothing is still running, and on a re-read at 2026-09-15T20:53:30Z the head, main and every latest run are unchanged. I did not rebuild, because the two files are byte-identical to what I built and linted at |
|
Codex verification follow-up at I inspected both completed Django job logs from CI35020126160: ordinary 3,852 tests / 436 expected skips, 1217.010s; scoped 367 / 0, 660.021s; EVM 63 / 0, 131.838s; Bitcoin 4 / 0, 16.009s; real services 15 / 0. Schema comparison and the172-policy/43-table/5-helper catalogue checks passed. The remaining latest CI/native-scope results are complete and successful; Android/iOS rebuilds were skipped by scope. The failed initial metadata run35020125654 was superseded by successful35020195381 after the bot's title/body reset was repaired. No source or observed validation blocker from this independent read. Claude still performs its normal immediate head/main/slot verification before merge. |
Refs #607
Bumps the all group with 3 updates in the /marketing directory: rollup, vite and @rollup/rollup-linux-arm64-musl.
Updates
rollupfrom 4.63.1 to 4.63.2Release notes
Sourced from rollup's releases.
Changelog
Sourced from rollup's changelog.
Commits
43ed4ec4.63.247282dachore(deps): update dtolnay/rust-toolchain digest to 6bed076 (#6512)ce22c33Fix nested log filters for primitive values (#6511)d05409ffix(deps): update minor/patch updates (#6513)02340ecdocs: fix AGENTS.md 'Generated files' rule to reference real paths (#6508)e90004achore(deps): lock file maintenance (#6510)e90af89fix(deps): update minor/patch updates (#6503)9281e77chore(deps): update dependency eslint-plugin-unicorn to v74 (#6504)a2a688epin mocha to v11 (#6505)f03c377chore(deps): lock file maintenance (#6498)Updates
vitefrom 8.2.2 to 8.3.0Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
95e8923release: v7.3.19d39d37feat: addignoreOutdatedRequestsoption tooptimizeDeps(#21364)acf7e05release: v7.3.0cff26ecfeat(deps): update esbuild from ^0.25.0 to ^0.27.0 (#21183)317b3b2release: v7.2.7721f163fix: plugin shortcut support (#21211)bda5dbbrelease: v7.2.63aa7527release: v7.2.572e398afix(deps): update all non-major dependencies (#21175)3765f7bfix: shortcuts not rebound after server restart (#21166)Updates
@rollup/rollup-linux-arm64-muslfrom 4.63.1 to 4.63.2Release notes
Sourced from @rollup/rollup-linux-arm64-musl's releases.
Changelog
Sourced from @rollup/rollup-linux-arm64-musl's changelog.
Commits
43ed4ec4.63.247282dachore(deps): update dtolnay/rust-toolchain digest to 6bed076 (#6512)ce22c33Fix nested log filters for primitive values (#6511)d05409ffix(deps): update minor/patch updates (#6513)02340ecdocs: fix AGENTS.md 'Generated files' rule to reference real paths (#6508)e90004achore(deps): lock file maintenance (#6510)e90af89fix(deps): update minor/patch updates (#6503)9281e77chore(deps): update dependency eslint-plugin-unicorn to v74 (#6504)a2a688epin mocha to v11 (#6505)f03c377chore(deps): lock file maintenance (#6498)