Skip to content

fixing minor spelling mistake#44

Open
Eiernase wants to merge 1 commit into
Leantime:masterfrom
Eiernase:patch-1
Open

fixing minor spelling mistake#44
Eiernase wants to merge 1 commit into
Leantime:masterfrom
Eiernase:patch-1

Conversation

@Eiernase

Copy link
Copy Markdown

Pacakge

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review (advisory — merge authority stays with @marcelfolaron / @broskees)

Intent: Fixes the PacakgePackage spelling in the bullet describing package-based installation in installation/system-requirements.md.

Change requests: None — the single-line diff is correct and scoped.

  • installation/system-requirements.md:5Package based installation reads correctly. ✔

Note: this is the oldest open PR in this repo (opened 2025-07-28, ~344 days) and is trivially safe; recommend prioritizing it to clear the backlog.

Acceptance checklist (must pass before merge):

  1. CLA signed / green (first-time contributor).
  2. Rendered docs page shows the corrected word with no Markdown breakage.
  3. N/A — no schema/API/behavior change (docs typo only).

CI status: No CI test gate applies to a docs typo; only the CLA/first-time-contributor check is relevant. Not a blocker beyond CLA.

@marcelfolaron

Copy link
Copy Markdown
Contributor

Maintainer review — status: ready (advisory) · priority: P3 · next action: maintainer merge · owner: @marcelfolaron

Thanks for the fix, and apologies this sat so long — this is the oldest open PR in the repo (opened 2025-07-28).

1. Intent: Corrects the spelling of "Pacakge" → "Package" in installation/system-requirements.md.

2. Change requests: None. The one-line diff at installation/system-requirements.md:5 is correct and self-contained:

-- **Pacakge based installation** requires a Linux Distribution, preferably Ubuntu 20.04+.
+- **Package based installation** requires a Linux Distribution, preferably Ubuntu 20.04+.

3. Acceptance checklist (must pass before merge):

  • Docs build/link-check CI green (or, if docs has no CI, a maintainer eyeballs the rendered page)
  • No behavior change — docs-only, so no test required
  • Confirm this doesn't conflict with fixed install links #51 (which also edits installation/) — different file, so should be clean

4. CI status: I can't read check-run status through my current tooling this cycle, so please confirm CI is green in the GitHub UI before merging. No behavior change and no tests are needed for a docs typo, so the missing-tests-is-a-blocker rule does not apply here.

Advisory review only — not an approval. Merge authority stays with @marcelfolaron / @broskees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants