Skip to content

test(scheduler): kick the stale refresh with an unrestricted reader #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Oct 16, 2026
Merged

test(scheduler): kick the stale refresh with an unrestricted reader #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/scheduler/scheduler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,10 +942,12 @@ func TestScheduler_ListRecommendations(t *testing.T) {
// ListRecommendations with the given RecommendationsCacheStaleHours. The first
// GetGlobalConfig call (the TTL resolution) succeeds; any later call can only
// come from the background refresh's CollectRecommendations, so it signals the
// returned channel and fails, which ends the refresh immediately.
// returned channel and fails, which ends the refresh immediately. The read
// runs as an unrestricted reader (WithBackgroundCollection), the only caller
// allowed to kick a refresh; without it neither TTL case could ever refresh.
func staleListRecommendations(t *testing.T, staleHours int) <-chan struct{} {
t.Helper()
ctx := context.Background()
ctx := WithBackgroundCollection(context.Background())
mockStore := new(MockConfigStore)

old := time.Now().Add(-72 * time.Hour)
Expand Down
Loading